[FE] モーダル UX 改善 #442
Merged
[FE] モーダル UX 改善 #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popunbom
force-pushed
the
feat/frontend/improve-modal-ux
branch
from
8f78117 to
da27db2
Compare
|
@imamiya-masaki @narirou レビューお願いいたします。 |
narirou
reviewed
Nov 27, 2024
| selectorModalRef.current.close(); | ||
| } | ||
| }, []); | ||
| // internalState: AppRequestContext.status をもとに決定する内部 status |
There was a problem hiding this comment.
コメントは書かなくて大丈夫です! 変数名を明示的にしたり、コードをシンプルにすることで担保してもらえたらと
それでもわからないWhyがあるときだけ記載をお願いします 🙇
narirou
reviewed
Nov 27, 2024
| return; | ||
| } | ||
| setInternalStatus("MATCHING"); | ||
| await fetchAppPostRides({ |
There was a problem hiding this comment.
try-catchにしてエラーハンドリングしてもらえると助かります!
| }); | ||
| }, [currentLocation, destLocation]); | ||
| // 少し時間をおいた後、Modal 要素を DOM から外す | ||
| setTimeout(() => setStatusModalOpen(false), 300); |
There was a problem hiding this comment.
(IMO) animationendイベントがあるのでこちらを見ても良いです
https://developer.mozilla.org/en-US/docs/Web/API/Element/animationend_event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates: #241
上記の対応を実施しました。
加えてモーダルクローズ時のアニメーション関連処理を修正しました。
トップの配車ボタン押下時に、API完了を待たずにモーダルをすぐ表示する
improve-modal-01.mov
到着画面で評価を押した後に、API完了を待たずにモーダルをすぐ閉じる
improve-modal-02.mov