[Frontend] Owner 画面（椅子一覧、売上）、Client 画面モーダルに値段表示 #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| return ( | ||
| <Text {...rest}>{new Intl.NumberFormat("ja-JP").format(value)} 円</Text> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
こちら、よき感じで cherry-pick いただけるとありがたいです 🙏
058882b
yamacent
changed the title
yamacent
requested review from
imamiya-masaki and
narirou
and removed request for
imamiya-masaki
imamiya-masaki
approved these changes
Nov 15, 2024
narirou
reviewed
Nov 15, 2024
| className?: string; | ||
| }>; | ||
|
|
||
| export function List<T>({ |
There was a problem hiding this comment.
List、ListItem にコンポーネントを分けたほうが、管理がしやすいでしょうか？
There was a problem hiding this comment.
@narirou
ListItem 追加しました！
narirou
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#241
（椅子一覧画面もついでに作成）
確認用 URL: http://localhost:3000/owner?id=xxx&name=%E3%82%A4%E3%82%B9%E3%82%B3%E3%83%B3%E5%A4%AA%E9%83%8E