docker-composeの追加 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takonomura
approved these changes
Jun 18, 2021
There was a problem hiding this comment.
軽く見た感じ良さそうです。
この PR とは別に後でやっても良さそうですが、 grpc_kit もリポジトリ&ブランチ指定やめて最新にできそうな気がします。 (未確認ですが確か ISUCON 用に当ててたパッチは本家に取り込まれたはずなので)
isucon11-portal/portal/Gemfile
Line 11 in 5a34b8e
|
MySQL起動時に文字コード設定しないとチーム名などの日本語周りでエラー出ます |
|
gemのほうはissueのほうに追記しておきます 文字コードのエラーは手元では出力されてなかったんですが、あったほうがいいのは確かなので追加しました |
|
GPG keyでこける問題のワークアラウンド追加しておきました |
sapphi-red
requested review from
takonomura and
nana4gonta
and removed request for
takonomura
|
あ、これアサイニーだけじゃなくレビューアも1人までしかつけれないんですね… |
Open
This was referenced Jun 21, 2021
nana4gonta
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #7