Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh] Sync #16044 set prev and next for Ambient get start doc into Chinese #16169

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

wilsonwu
Copy link
Member

Description

Sync #16044 set prev and next for Ambient get start doc into Chinese

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@wilsonwu wilsonwu added the translation/chinese Translation item label Jan 14, 2025
@wilsonwu wilsonwu requested a review from a team as a code owner January 14, 2025 07:34
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2025
Copy link
Contributor

@AdeshGhadage AdeshGhadage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wilsonwu I think you should remove "/zh" from prev and next url then it will work. i got same issue in english as well.

@wilsonwu
Copy link
Member Author

@wilsonwu I think you should remove "/zh" from prev and next url then it will work. i got same issue in english as well.

Not sure it will go to correct Chinese next or prev page by remove the "/zh"?

@AdeshGhadage
Copy link
Contributor

Not sure it will go to correct Chinese next or prev page by remove the "/zh"?

it will direct to correct chinese next or prev i have checked it locally also

@wilsonwu
Copy link
Member Author

@wilsonwu I think you should remove "/zh" from prev and next url then it will work. i got same issue in english as well.

Done, thank you so much for your help and test.

@istio-testing istio-testing merged commit ad927de into istio:master Jan 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants