Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry picking intuit changes for LB migration #391

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

virajrk
Copy link
Collaborator

@virajrk virajrk commented Feb 24, 2025

Checklist

🚨 Please review this repository's contribution guidelines.

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

What does this change do and why?

[Link to related ISSUE]

Thank you!

@virajrk virajrk force-pushed the cherrypick-intuit-changes branch from 27c4ae8 to 55d00f6 Compare February 24, 2025 23:05
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.31373% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.92%. Comparing base (1ee9879) to head (55d00f6).

Files with missing lines Patch % Lines
admiral/pkg/clusters/admiralDatabaseClient.go 70.37% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
- Coverage   76.92%   76.92%   -0.01%     
==========================================
  Files          71       71              
  Lines       10715    10747      +32     
==========================================
+ Hits         8243     8267      +24     
- Misses       2062     2067       +5     
- Partials      410      413       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants