Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html: Fix W3C Validation issues #999

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

pkvach
Copy link
Contributor

@pkvach pkvach commented Mar 13, 2024

Checklist

  • All new and existing tests are passing
  • I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
  • I have written proper commit message(s)

What changes does this Pull Request introduce?

Fixing following W3C validation issues in HTML:

  • Error: Bad value meta for attribute role on element div.
  • Warning: Section lacks heading. Consider using h2-h6 elements to add identifying headings to all sections, or else use a div element instead for any cases where no heading is needed.
  • Warning: Consider adding a lang attribute to the html start tag to declare the language of this document.
  • Warning: The type attribute is unnecessary for JavaScript resources.

Why is this necessary?

Fixes #328

@jelmer jelmer merged commit d9f066a into isso-comments:master Mar 14, 2024
14 checks passed
@pkvach pkvach deleted the fix/w3c-validation-issues branch March 14, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

W3C Validation is NOK
2 participants