Truncate arrays if they are longer in recomp

[disinvite]

_match_array_elements adds offset entities for each array variable. We need this if array entries are referenced by pointers in other variables because datacmp only checks the database for a pointer match. (e.g. g_skBMap and g_skeletonKickPhases)

This function assumes the arrays are the same size in orig as in recomp. This is not always true for BETA10 and so the offsets we generate will clash with the ones from the following variable. We can detect when this occurs by looking at the next orig address. If recomp is larger, we add the extra offsets on the recomp side only and not link them to orig.

You can use roadmap --verbose to see what changed. I'll attach the BETA10 diff here. No change to LEGO1.
truncate-array-roadmap-beta10.txt

IIRC the ghidra scripts do not reference these offsets and use the cvdump data directly to build out the types. Is that right @jonschz?

[jonschz]

Looks good! You are correct, these array elements are not used by the Ghidra import. I originally added them because datacmp would raise errors on correct data.

[disinvite]

Thanks! Let me know how it looks now. I had to add the dreaded # pylint: disable=too-many-lines to the file, but I have some upcoming changes planned that will shrink this back down.

[jonschz]

looks good!