Start on support for NE EXE #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks fine from what I can tell. Is this a WIP or do you want to merge this in batches? Also, do you have an example file for experiments / also potentially for a unit test? |
|
This is it for now. I had these files unstaged and thought I would finish them up and get them out of the way. We should have tests, but there is still the question (from #3) of where to put them and how to build. NE might require an old compiler too. |
|
Do you know what compiler your executables were created with? |
jonschz
approved these changes
Dec 31, 2024
jonschz
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some NE format programs I want to start looking at. I followed the layout of the other file formats and used the same member names as the Windows header files.