chore(j-s): Move CaseFiles step forward

[oddsson]

Move CaseFiles step forward

Asana

What

Move CaseFiles step forward. Note that to be able to do this, we had to remove the indictment PDF button from this screen because it uses data from the Indictment screen that is now behind the CaseFiles screen. This was given the go-ahead by our designer.

Why

This was a request from some prosecutor users. Apparently this makes more sense to them.

Screenshots / Gifs

Before

After

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Updated navigation flows across multiple screens to ensure a more consistent user journey.

• Bug Fixes

  • Removed the PDF download option from the case files interface.

• Refactor

  • Revised workflow steps and section labels for clearer progression.

• Style

  • Adjusted layout spacing in key sections for improved visual clarity.

[coderabbitai]

Walkthrough

This pull request updates several components in the Prosecutor module to modify their navigation logic. The changes update the target routes for the next and previous actions in the FormFooter components, remove PDF generation functionality and its associated localization string, adjust UI spacing in one component, and update the naming and routing logic within a custom hook. Overall, the modifications affect how users are redirected among case files, indictments, and overview screens.

Changes

Files	Change Summary
apps/judicial-system/web/src/routes/Prosecutor/Indictments/CaseFile/CaseFile.tsx, apps/judicial-system/web/src/routes/Prosecutor/Indictments/Indictment/Indictment.tsx, apps/judicial-system/web/src/routes/Prosecutor/Indictments/Overview/Overview.tsx, apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx	Updated FormFooter navigation routes by changing onNextButtonClick and previousUrl properties to new route constants, thereby altering the redirection flow between case file, indictment, overview, and processing screens.
apps/judicial-system/web/src/routes/Prosecutor/Indictments/CaseFiles/CaseFiles.tsx	Removed the PdfButton component (and its functionality) and increased the margin for the civil claims section to adjust the layout.
apps/judicial-system/web/src/routes/Prosecutor/Indictments/CaseFiles/CaseFiles.strings.ts	Removed the pdfButtonIndictment message definition from the caseFiles object, eliminating the PDF download text.
apps/judicial-system/web/src/utils/hooks/useSections/index.ts	Renamed a section from "processing" to "caseFiles" and updated its properties (name, href, isActive) and onClick logic for navigation to align with the new routing requirements.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant F as FormFooter
    participant R as Router

    U->>F: Click navigation button (Next/Previous)
    F->>R: Invoke navigation with updated route constant
    R-->>U: Render the new page based on the route

Loading

Possibly related PRs

• fix(j-s): Remove required criminal record upload in indictments #16563: Involves changes in the CaseFiles.tsx component with a focus on file upload validation; shares a common code area with the navigation updates applied here.

Suggested labels

automerge

Suggested reviewers

• gudjong

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8f8c7e3 and 198e849.

📒 Files selected for processing (1)

• apps/system-e2e/src/tests/judicial-system/regression/indictment-tests.spec.ts (3 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`apps/**/*`: "Confirm that the code adheres to the following...

apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

• apps/system-e2e/src/tests/judicial-system/regression/indictment-tests.spec.ts

🔇 Additional comments (3)

apps/system-e2e/src/tests/judicial-system/regression/indictment-tests.spec.ts (3)

37-39: LGTM! Robust prosecutor selection implementation.

The added steps for prosecutor selection use recommended Playwright practices with role-based selectors.

---

79-84: LGTM! Case files step correctly implements new workflow.

The added case files step properly verifies the new navigation flow and maintains consistency with the existing test patterns.

---

86-86: LGTM! Comments accurately reflect workflow changes.

The updated comments properly document the new step order and maintain clarity in the test flow.

Also applies to: 107-107

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 198e849.

Command	Status	Duration	Result
nx run-many --target=build --projects=judicial-...	✅ Succeeded	6m 52s	View ↗
nx run-many --projects judicial-system-web --ta...	✅ Succeeded	3m 49s	View ↗
nx run-many --target=lint --projects=judicial-s...	✅ Succeeded	17s	View ↗
nx run-many --target=build --projects=system-e2...	✅ Succeeded	5s	View ↗
nx run-many --target=codegen/frontend-client --...	✅ Succeeded	12s	View ↗
nx run-many --target=codegen/backend-schema --a...	✅ Succeeded	21s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-02-14 12:19:47 UTC

[unakb]

This change looks good and works locally, but you need to also adjust the e2e tests to accommodate the change of steps 🙏