Fixes, update docs

isl-org · Jan 3, 2024 · 4164f16 · 4164f16
1 parent 345d0c8
commit 4164f16
Show file tree

Hide file tree

Showing 6 changed files with 45 additions and 31 deletions.
diff --git a/cpp/apps/Open3DViewer/Debian/CMakeLists.in.txt b/cpp/apps/Open3DViewer/Debian/CMakeLists.in.txt
@@ -4,6 +4,10 @@ project("Open3D-Debian")
 
 message(STATUS "Building package for Debian")
 
+# How to set cpack prefix: https://stackoverflow.com/a/7363073/1255535
+set(CPACK_SET_DESTDIR true)
+set(CPACK_INSTALL_PREFIX /usr/local)
+
 # Install assets
 install(DIRECTORY   "Open3D"
         DESTINATION share
@@ -32,8 +36,4 @@ set(CPACK_PACKAGE_VERSION "@OPEN3D_VERSION@")
 set(CPACK_DEBIAN_PACKAGE_DEPENDS "libc++1, libgomp1, libpng16-16, libglfw3")
 set(CPACK_PACKAGE_HOMEPAGE_URL "@PROJECT_HOMEPAGE_URL@")
 
-# How to set cpack prefix: https://stackoverflow.com/a/7363073/1255535
-set(CPACK_SET_DESTDIR true)
-set(CPACK_INSTALL_PREFIX /usr/local)
-
 include(CPack)
diff --git a/cpp/apps/Open3DViewer/Open3DViewerLauncher.sh b/cpp/apps/Open3DViewer/Open3DViewerLauncher.sh
@@ -4,4 +4,4 @@
 SCRIPT=$(readlink -f "$0")
 INSTALL_DIRECTORY=$(readlink -f $(dirname "$SCRIPT")/..)
 OPEN3D_PATH="$INSTALL_DIRECTORY/share/Open3D/Open3D"
-nohup "$OPEN3D_PATH" "$@" &
+"$OPEN3D_PATH" "$@" &
diff --git a/docs/arm.rst b/docs/arm.rst
@@ -171,13 +171,14 @@ Compiling Open3D on ARM64 macOS
     # Optional: activate your virtualenv
     conda activate your-virtual-env
 
-    # Configure
+    # Configure and choose build options
     cd Open3D && mkdir build && cd build
-    cmake ..
+    cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_TENSORFLOW_OPS=ON -DBUILD_PYTORCH_OPS=ON ..
 
     # Build
-    make -j8
-    make install-pip-package -j8
+    make pip-package -j8    # Build Python wheel
+    make package -j8        # Build macOS devel binary package
+    make Open3DViewer -j8   # Build Open3D viewer app
 
     # Test C++ viewer app
     ./bin/Open3D/Open3D

diff --git a/docs/getting_started.in.rst b/docs/getting_started.in.rst
@@ -153,10 +153,10 @@ C++
 To get started with using Open3D in your C++ applications, you can download a
 binary package archive from `Github releases
 <https://github.com/isl-org/Open3D/releases>`__ (since `v0.15`). These binary
-package archives contain the Open3D shared library built with all supported
-features and are available for the main supported platforms. Also, the latest
-development version (``HEAD`` of ``main`` branch) binary package archives are
-provided here [#]_:
+package archives contain the Open3D shared library, include headers and GUI /
+rendering resources. These are built with all supported features and are
+available for the main supported platforms. Also, the latest development version
+(``HEAD`` of ``main`` branch) binary package archives are provided here [#]_:
 
 :Linux (Ubuntu 18.04+ or glibc 2.27+ [#]_):
     .. hlist::
@@ -203,19 +203,30 @@ Extract the archive and move the contents to a local folder (such as
     Linux / MacOSX:                       Windows:
     Open3D_install                        Open3D_install
     ├── include                           ├── bin
-    │   └── open3d                        │   └── Open3D.dll
-    │       ├── core                      ├── CMake
-    │       ├── ...                       │   ├── Open3DConfig.cmake
-    │       ├── Open3DConfig.h            │   ├── ...
-    │       ├── Open3D.h                  ├── include
-    │       ├── ...                       │   └── open3d
-    └── lib                               │       ├── core
-        ├── cmake                         │       ├── ...
-        │   └── Open3D                    │       ├── Open3DConfig.h
-        │        ├── ...                  │       ├── Open3D.h
-        ├── libOpen3D.so                  │       ├── ...
-        ├── open3d_tf_ops.so              └── lib
-        └── open3d_torch_ops.so               └── Open3D.lib
+    │   └── open3d                        │   ├── Open3D.dll
+    │       ├── core                      │   └── resources
+    │       ├── ...                       │       ├── brightday_ibl.ktx
+    │       ├── Open3DConfig.h            │       ├── ...
+    │       ├── Open3D.h                  │
+    │       ├── ...                       ├── CMake
+    ├── lib                               │   ├── Open3DConfig.cmake
+    │   ├── cmake                         │   ├── ...
+    │   │   └── Open3D                    ├── include
+    │   │        ├── ...                  │   └── open3d
+    │   ├── pkgconfig                     │       ├── core
+    │   │   ├── Open3D.pc                 │       ├── ...
+    │   │   ├── ...                       │       ├── Open3DConfig.h
+    |   |                                 │       ├── Open3D.h
+    │   ├── libOpen3D.so                  │       ├── ...
+    │   ├── open3d_tf_ops.so              └── lib
+    │   └── open3d_torch_ops.so               └── Open3D.lib
+    └── share
+        └── resources
+            ├── html
+            │    ├── ...
+            ├── brightday_ibl.ktx
+            ├── ...
+
 
 Some files may be absent in the case of unsupported functionality. To use Open3D
 with your programs through `cmake`, add ``-D

diff --git a/docs/release.md b/docs/release.md
@@ -19,10 +19,12 @@ Collect all release artifacts in the [Github draft release page](https://github.
     -   [ ] macOS 12 arm64 (desktop)
     -   [ ] macOS (x86_64, arm64) sign (desktop)
     -   [ ] Windows app sign
--   [ ] Upload wheels to PyPI
+-   [ ] Testing: Run all (especially visualization) examples and Open3D viewer with
+        (Suzanne, Khronos helmet, large point cloud - apartment), on Linux x86-64,
+        macOS (x86-64, arm64), Windows x86-64.
+-   [ ] PyPI: Upload wheels
 -   [ ] Github: Publish release with auto tag version
--   [ ] Github: Create Open3D-ML release (auto tag version, auto-generate release
-    notes)
+-   [ ] Github: Create Open3D-ML release (auto tag version, auto-generate release notes)
 -   [ ] `git pull` docs to website (Google cloud server `open3d:instance1`)
 -   [ ] open3d.org (wordpress) : Update downloads table and post release notes
 -   [ ] Upload release video to YouTube

diff --git a/docs/versions.js b/docs/versions.js
@@ -22,8 +22,8 @@ document.write('\
             <td><a href="https://www.open3d.org/docs/release/cpp_api">0.18.0 C++ (release)</a></td>\
         </tr>\
         <tr>\
-            <td><a href="https://www.open3d.org/docs/0.17.0">0.17.0 (release)</a></td>\
-            <td><a href="https://www.open3d.org/docs/0.17.0/cpp_api">0.17.0 C++ (release)</a></td>\
+            <td><a href="https://www.open3d.org/docs/0.17.0">0.17.0</a></td>\
+            <td><a href="https://www.open3d.org/docs/0.17.0/cpp_api">0.17.0 C++</a></td>\
         </tr>\
         <tr>\
             <td><a href="https://www.open3d.org/docs/0.16.0">0.16.0</a></td>\