[pull] master from RestComm:master #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
added 30 commits
June 20, 2017 13:18
…ome tests to fix our new ICE configuration URL; the work to make it pluggable will start later
…ang.NullPointerException: Attempt to invoke virtual method 'void org.restcomm.android.sdk.RCConnection.setConnectionListener(org.restcomm.android.sdk.RCConnectionListener)' on a null object reference
…for Awaitility to be able to test asychronous code. Have issues with threads + service
… issues, but now having a pretty bad design that won't cut it. Needs more work
…ign, where we have one looper for the testing thread and so are in a position to notify that we are done
…th handling events with loopers is that it needs considerable work to model properly so that test cases are maintainable (that is in order to keep test logic in one place). Tried falling back to using Awaitility but in a slightly different fashion. Creating a separate thread for the SDK (that is separate from test case thread) and using awaitility facilities in test case thread. Although this works once the thred does it's work you cannot really hold on to it to do more stuff unless you start putting test logic all over the place (i.e. in RCDevice callbacks). Need to investigate more
…o hold on to the thread, by using Looper and Handler. That way we can send additional messages by means of Handler.post(). We are then able to consecutively test multiple signaling actions. The problem now is with ServiceTestRule that seems to mess up in the second time bindService is called
…vercome the issue with ServiceTestRule, but removing it altogether and instead handle the async Service callbacks using Awaitility. Next up is an issue with threading, where the signaling facilities are a Singleton and hence in consecutive TCs we cannot update the thread
…tarted to work finally across 2 TCs, need some more work to improve a couple of things here and there
…asic TCs and stated adding full assertions (currently only for voice call). Improved condition variables and added context to share state between API thread and testing thread, so that assertions can work. Started documented the whole thing
…xed build issue with app_name in SDK. Introduced new icons to separate community vs premium in our devices. Various cleanups
…-sdk # Conflicts: # Examples/restcomm-olympus/app/app.iml
Merge and small changes
Removed push configuration from hello world.
Gradle properties enc updated
Also updated link to acknowledgements and removed outdated cloudbees link
Please refer to #844 for detailed information
Update readme
Fixed connection to RC server when on cellular data
Added documentation
Fix for issue 855. Android 28 Compatibility issue fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )