-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fixes and small adjustments #34
Conversation
packages/isar/pubspec.yaml
Outdated
@@ -14,10 +14,12 @@ environment: | |||
|
|||
dependencies: | |||
ffi: ">=2.0.0 <3.0.0" | |||
isar_test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need this extra dependency (for everybody using Isar)?
isar: | ||
version: 3.1.4 | ||
hosted: https://isar-community.dev/ | ||
isar: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Referring local paths won't work for everybody else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Referring to local paths in pubspec works for your (or the github action) setup, but not for the end user...
Do you have a use case where this will not work for end users? |
Uhm for everyone :) |
Should be an easy change after publishing then |
we might need to consider https://melos.invertase.dev/ for local packages this can help when it is time to publish as well to pub.dev |
Looks good to me |
No description provided.