-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial update for v4 in quickstart guide #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes should be made in all language files!
## 3. Code-Generator ausführen | ||
|
||
Führe den folgenden Befehl aus, um den `build_runner` zu starten: | ||
|
||
``` | ||
dart run build_runner build | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, these lines where deleted accidentally!
It's still necessary to run
dart run build_runner build
only the Flutter part can be deleted so
flutter pub run build_runner build
isn't needed anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might be right. I ran that all the time to regenerate the files, but didn't think it's absolutely necessary.
Sure, I just wanted to get feedback (like yours below) before modifying all files. Feel free to create a pull request that adapts all languages and your objection comment. I'm trying to fix the release build right now, so I can't do that at the moment... |
I'll fix this now, I want to remove the manual versions from the docs... |
Initial quickstart guide update for German and English