Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial update for v4 in quickstart guide #23

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Initial update for v4 in quickstart guide #23

merged 2 commits into from
Mar 8, 2024

Conversation

mrclauss
Copy link
Member

@mrclauss mrclauss commented Mar 7, 2024

Initial quickstart guide update for German and English

@mrclauss mrclauss requested review from vicenterusso and mdmm13 March 7, 2024 20:40
@mrclauss mrclauss merged commit 97eec6e into main Mar 8, 2024
12 of 17 checks passed
@mrclauss mrclauss deleted the v4docs branch March 8, 2024 12:19
Copy link

@Bohne13 Bohne13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes should be made in all language files!

Comment on lines -39 to -46
## 3. Code-Generator ausführen

Führe den folgenden Befehl aus, um den `build_runner` zu starten:

```
dart run build_runner build
```

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, these lines where deleted accidentally!
It's still necessary to run

dart run build_runner build

only the Flutter part can be deleted so

flutter pub run build_runner build

isn't needed anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be right. I ran that all the time to regenerate the files, but didn't think it's absolutely necessary.

@mrclauss
Copy link
Member Author

mrclauss commented Mar 8, 2024

This changes should be made in all language files!

Sure, I just wanted to get feedback (like yours below) before modifying all files. Feel free to create a pull request that adapts all languages and your objection comment. I'm trying to fix the release build right now, so I can't do that at the moment...

@mrclauss
Copy link
Member Author

mrclauss commented Mar 8, 2024

I'll fix this now, I want to remove the manual versions from the docs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants