Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collision approximation choices convert_mesh.py #1716

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

virgilio96upm
Copy link

Add missing collision approximation choices

Description

Add some missing collision approximation options in convert_mesh.py file. Some collision approximation options were missing in the code, but the MeshConverterCfg class has them as possible options

choices=["convexDecomposition", "convexHull", "none"],

Valid options are:
"convexDecomposition", "convexHull", "boundingCube",
"boundingSphere", "meshSimplification", or "none"

Fixes #1713 (comment)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Missing choices available in MeshConverterCfg added

Signed-off-by: Virgilio Gomez Lambo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Add missing collision approximation choices
1 participant