feat: feat(NavMeshQuery): don't return 'polyCount' from queryPolygons…

…, only incldue 'polyRefs' from 0 to 'polyCount'
isaac-mason · Nov 30, 2024 · 753e4e2 · 753e4e2
1 parent bb3e49a
commit 753e4e2
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/.changeset/gold-hotels-cough.md b/.changeset/gold-hotels-cough.md
@@ -0,0 +1,5 @@
+---
+'@recast-navigation/core': minor
+---
+
+feat(NavMeshQuery): don't return 'polyCount' from queryPolygons, only incldue 'polyRefs' from 0 to 'polyCount'
diff --git a/packages/recast-navigation-core/src/nav-mesh-query.ts b/packages/recast-navigation-core/src/nav-mesh-query.ts
@@ -292,14 +292,13 @@ export class NavMeshQuery {
     const polyCount = polyCountRef.value;
     Raw.destroy(polyCountRef);
 
-    const polyRefs = [...polysRefsArray.getHeapView()];
+    const polyRefs = [...polysRefsArray.getHeapView()].slice(0, polyCount);
     polysRefsArray.destroy();
 
     return {
       success: statusSucceed(status),
       status,
       polyRefs,
-      polyCount,
     };
   }
 

diff --git a/packages/recast-navigation/.storybook/stories/nav-mesh-query/nearby-polygons.stories.tsx b/packages/recast-navigation/.storybook/stories/nav-mesh-query/nearby-polygons.stories.tsx
@@ -180,10 +180,7 @@ export function ClickNearbyPolygons() {
         findPolysAroundCircleResult.resultCount
       );
     } else {
-      polyRefs = queryPolygonsResult.polyRefs.slice(
-        0,
-        queryPolygonsResult.polyCount
-      );
+      polyRefs = queryPolygonsResult.polyRefs;
     }
 
     const decodedPolyRefs = polyRefs.map((polyRef) =>
@@ -355,7 +352,7 @@ function polyRefToGeom(
  */
 function range(n: number) {
   return [...Array(n)].map((_, i) => i);
-};
+}
 
 const navMeshMaterial = new THREE.MeshBasicMaterial({
   wireframe: true,