-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded to DJ 4.0.0 and added -1 config.timeout option #7
Conversation
… queue after they've been reserved by a worker.
@@ -1,9 +1,9 @@ | |||
source 'http://rubygems.org' | |||
|
|||
gem 'iron_mq', '>= 4.0.0' | |||
gem 'delayed_job', '~> 3.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this no longer work with 3 then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be fine with > 3.0.0, however I did not test my changes with delayed_job ~3.0.0. The only real change to make the lib work with 4.0.0 was adding a Job.id attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then it probably shouldn't force 4+ otherwise we leave out all the 3.0 users. Can you change the Gemfile to > 3.0.0?
Needs more testing, seeing some odd behaviour. |
@sawyer could you explain what issues are you having? I would be happy to investigate some more tests to get this rolled out |
I've been getting very odd behaviour all day - messages coming off the queue without triggering the Job initializer (for instance, no "[init] Delayed::Backend::Ironmq" showing up in the logs. I'm running a multi-worker test right now pushing ~100 jobs onto the queue at a time, they all appear to get there no problem, and then after a 30s delay start to get pulled by the workers, but 0-3 jobs just seem to disappear without initializing a job. I've rolled back my -1 timeout change in case that was the culprit but it hasn't made a difference. Will update when I get to the bottom of it! |
Awesome, thanks! I might eventually test it out as well and see what I find out. |
This should address issue #3 and #6.