Skip to content
CI checks

Bump the dependency on ironfish-bellperson #40

Sign in to view logs

Bump the dependency on ironfish-bellperson

Bump the dependency on ironfish-bellperson #40

GitHub Actions / Clippy (beta) failed Feb 4, 2025 in 0s

Clippy (beta)

4 errors, 43 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 4
Warning 43
Note 0
Help 0

Versions

  • rustc 1.85.0-beta.7 (0277061b9 2025-02-01)
  • cargo 1.85.0-beta.7 (d73d2caf9 2024-12-31)
  • clippy 0.1.85 (0277061b9a 2025-02-01)

Annotations

Check warning on line 298 in components/zcash_address/src/kind/unified/ivk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

useless use of `vec!` 

warning: useless use of `vec!`
   --> components/zcash_address/src/kind/unified/ivk.rs:291:23
    |
291 |           let encoded = vec![
    |  _______________________^
292 | |             0x12, 0x51, 0x37, 0xc7, 0xac, 0x8c, 0xd, 0x13, 0x3a, 0x5f, 0xc6, 0x84, 0x53, 0x90,
293 | |             0xf8, 0xe7, 0x23, 0x34, 0xfb, 0xda, 0x49, 0x3c, 0x87, 0x1c, 0x8f, 0x1a, 0xe1, 0x63,
294 | |             0xba, 0xdf, 0x77, 0x64, 0x43, 0xcf, 0xdc, 0x37, 0x1f, 0xd2, 0x89, 0x60, 0xe3, 0x77,
...   |
297 | |             0xbd, 0xfe, 0xa4, 0xb7, 0x47, 0x20, 0x92, 0x6, 0xf0, 0x0, 0xf9, 0x64,
298 | |         ];
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
help: you can use an array directly
    |
291 ~         let encoded = [0x12, 0x51, 0x37, 0xc7, 0xac, 0x8c, 0xd, 0x13, 0x3a, 0x5f, 0xc6, 0x84, 0x53, 0x90,
292 +             0xf8, 0xe7, 0x23, 0x34, 0xfb, 0xda, 0x49, 0x3c, 0x87, 0x1c, 0x8f, 0x1a, 0xe1, 0x63,
293 +             0xba, 0xdf, 0x77, 0x64, 0x43, 0xcf, 0xdc, 0x37, 0x1f, 0xd2, 0x89, 0x60, 0xe3, 0x77,
294 +             0x20, 0xd0, 0x1c, 0x5, 0x40, 0xe5, 0x43, 0x55, 0xc4, 0xe5, 0xf8, 0xaa, 0xe, 0x7a, 0xe7,
295 +             0x8c, 0x53, 0x15, 0xb8, 0x8f, 0x90, 0x14, 0x33, 0x30, 0x52, 0x2b, 0x8, 0x89, 0x90,
296 ~             0xbd, 0xfe, 0xa4, 0xb7, 0x47, 0x20, 0x92, 0x6, 0xf0, 0x0, 0xf9, 0x64];
    |

Check warning on line 270 in components/zcash_address/src/kind/unified/ivk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

useless use of `vec!` 

warning: useless use of `vec!`
   --> components/zcash_address/src/kind/unified/ivk.rs:264:48
    |
264 |           let truncated_after_sapling_typecode = vec![
    |  ________________________________________________^
265 | |             0xf7, 0x3, 0xd8, 0xbe, 0x6a, 0x27, 0xfa, 0xa1, 0xd3, 0x11, 0xea, 0x25, 0x94, 0xe2, 0xb,
266 | |             0xde, 0xed, 0x6a, 0xaa, 0x8, 0x46, 0x7d, 0xe4, 0xb1, 0xe, 0xf1, 0xde, 0x61, 0xd7, 0x95,
267 | |             0xf7, 0x82, 0x62, 0x32, 0x7a, 0x73, 0x8c, 0x55, 0x93, 0xa1, 0x63, 0x75, 0xe2, 0xca,
268 | |             0xcb, 0x73, 0xd5, 0xe5, 0xa3, 0xbd, 0xb3, 0xf2, 0x26, 0xfa, 0x1c, 0xa2, 0xad, 0xb6,
269 | |             0xd8, 0x21, 0x5e, 0x8, 0xa, 0x82, 0x95, 0x21, 0x74,
270 | |         ];
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
help: you can use an array directly
    |
264 ~         let truncated_after_sapling_typecode = [0xf7, 0x3, 0xd8, 0xbe, 0x6a, 0x27, 0xfa, 0xa1, 0xd3, 0x11, 0xea, 0x25, 0x94, 0xe2, 0xb,
265 +             0xde, 0xed, 0x6a, 0xaa, 0x8, 0x46, 0x7d, 0xe4, 0xb1, 0xe, 0xf1, 0xde, 0x61, 0xd7, 0x95,
266 +             0xf7, 0x82, 0x62, 0x32, 0x7a, 0x73, 0x8c, 0x55, 0x93, 0xa1, 0x63, 0x75, 0xe2, 0xca,
267 +             0xcb, 0x73, 0xd5, 0xe5, 0xa3, 0xbd, 0xb3, 0xf2, 0x26, 0xfa, 0x1c, 0xa2, 0xad, 0xb6,
268 ~             0xd8, 0x21, 0x5e, 0x8, 0xa, 0x82, 0x95, 0x21, 0x74];
    |

Check warning on line 257 in components/zcash_address/src/kind/unified/ivk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

useless use of `vec!` 

warning: useless use of `vec!`
   --> components/zcash_address/src/kind/unified/ivk.rs:245:38
    |
245 |           let truncated_sapling_data = vec![
    |  ______________________________________^
246 | |             0xce, 0xbc, 0xfe, 0xc5, 0xef, 0x2d, 0xe, 0x66, 0xc2, 0x8c, 0x34, 0xdc, 0x2e, 0x24,
247 | |             0xd2, 0xc7, 0x4b, 0xac, 0x36, 0xe0, 0x43, 0x72, 0xa7, 0x33, 0xa4, 0xe, 0xe0, 0x52,
248 | |             0x15, 0x64, 0x66, 0x92, 0x36, 0xa7, 0x60, 0x8e, 0x48, 0xe8, 0xb0, 0x30, 0x4d, 0xcb,
...   |
256 | |             0xf5, 0xd5, 0x8a, 0xb5, 0x1a,
257 | |         ];
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
help: you can use an array directly
    |
245 ~         let truncated_sapling_data = [0xce, 0xbc, 0xfe, 0xc5, 0xef, 0x2d, 0xe, 0x66, 0xc2, 0x8c, 0x34, 0xdc, 0x2e, 0x24,
246 +             0xd2, 0xc7, 0x4b, 0xac, 0x36, 0xe0, 0x43, 0x72, 0xa7, 0x33, 0xa4, 0xe, 0xe0, 0x52,
247 +             0x15, 0x64, 0x66, 0x92, 0x36, 0xa7, 0x60, 0x8e, 0x48, 0xe8, 0xb0, 0x30, 0x4d, 0xcb,
248 +             0xd, 0x6f, 0x5, 0xd4, 0xb8, 0x72, 0x6a, 0xdc, 0x6c, 0x5c, 0xa, 0xf8, 0xdf, 0x95, 0x5a,
249 +             0xba, 0xe1, 0xaa, 0x82, 0x51, 0xe2, 0x70, 0x8d, 0x13, 0x16, 0x88, 0x6a, 0xc0, 0xc1,
250 +             0x99, 0x3c, 0xaf, 0x2c, 0x16, 0x54, 0x80, 0x7e, 0xb, 0xad, 0x31, 0x29, 0x26, 0xdd,
251 +             0x7a, 0x55, 0x98, 0x1, 0x18, 0xb, 0x14, 0x94, 0xb2, 0x6b, 0x81, 0x67, 0x73, 0xa6, 0xd0,
252 +             0x20, 0x94, 0x17, 0x3a, 0xf9, 0x98, 0x43, 0x58, 0xd6, 0x1, 0x10, 0x73, 0x32, 0xb4,
253 +             0x99, 0xad, 0x6b, 0xfe, 0xc0, 0x97, 0xaf, 0xd2, 0xee, 0x8, 0xe5, 0x83, 0x6b, 0xb6,
254 +             0xd9, 0x0, 0xef, 0x84, 0xff, 0xe8, 0x58, 0xba, 0xe8, 0x10, 0xea, 0x2d, 0xee, 0x72,
255 ~             0xf5, 0xd5, 0x8a, 0xb5, 0x1a];
    |

Check warning on line 229 in components/zcash_address/src/kind/unified/ivk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

useless use of `vec!` 

warning: useless use of `vec!`
   --> components/zcash_address/src/kind/unified/ivk.rs:222:33
    |
222 |           let truncated_padding = vec![
    |  _________________________________^
223 | |             0x96, 0x73, 0x6a, 0x56, 0xbc, 0x44, 0x38, 0xe2, 0x47, 0x41, 0x1c, 0x70, 0xe4, 0x6,
224 | |             0x87, 0xbe, 0xb6, 0x90, 0xbd, 0xab, 0x1b, 0xd8, 0x27, 0x10, 0x0, 0x21, 0x30, 0x2, 0x77,
225 | |             0x87, 0x0, 0x25, 0x96, 0x94, 0x8f, 0x1e, 0x39, 0xd2, 0xd8, 0x65, 0xb4, 0x3c, 0x72,
...   |
228 | |             0xf9, 0x65, 0x49, 0x14, 0xab, 0x7c, 0x55, 0x7b, 0x39, 0x47,
229 | |         ];
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
help: you can use an array directly
    |
222 ~         let truncated_padding = [0x96, 0x73, 0x6a, 0x56, 0xbc, 0x44, 0x38, 0xe2, 0x47, 0x41, 0x1c, 0x70, 0xe4, 0x6,
223 +             0x87, 0xbe, 0xb6, 0x90, 0xbd, 0xab, 0x1b, 0xd8, 0x27, 0x10, 0x0, 0x21, 0x30, 0x2, 0x77,
224 +             0x87, 0x0, 0x25, 0x96, 0x94, 0x8f, 0x1e, 0x39, 0xd2, 0xd8, 0x65, 0xb4, 0x3c, 0x72,
225 +             0xd8, 0xac, 0xec, 0x5b, 0xa2, 0x18, 0x62, 0x3f, 0xb, 0x88, 0xb4, 0x41, 0xf1, 0x55,
226 +             0x39, 0x53, 0xbf, 0x2a, 0xd6, 0xcf, 0xdd, 0x46, 0xb7, 0xd8, 0xc1, 0x39, 0x34, 0x4d,
227 ~             0xf9, 0x65, 0x49, 0x14, 0xab, 0x7c, 0x55, 0x7b, 0x39, 0x47];
    |

Check warning on line 213 in components/zcash_address/src/kind/unified/ivk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

useless use of `vec!` 

warning: useless use of `vec!`
   --> components/zcash_address/src/kind/unified/ivk.rs:206:31
    |
206 |           let invalid_padding = vec![
    |  _______________________________^
207 | |             0xba, 0xbc, 0xc0, 0x71, 0xcd, 0x3b, 0xfd, 0x9a, 0x32, 0x19, 0x7e, 0xeb, 0x8a, 0xa7,
208 | |             0x6e, 0xd4, 0xac, 0xcb, 0x59, 0xc2, 0x54, 0x26, 0xc6, 0xab, 0x71, 0xc7, 0xc3, 0x72,
209 | |             0xc, 0xa9, 0xad, 0xa4, 0xad, 0x8c, 0x9e, 0x35, 0x7b, 0x4c, 0x5d, 0xc7, 0x66, 0x12,
...   |
212 | |             0x83, 0xe8, 0x92, 0x18, 0x28, 0x70, 0x1e, 0x81, 0x76, 0x56, 0xb6, 0x15,
213 | |         ];
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
help: you can use an array directly
    |
206 ~         let invalid_padding = [0xba, 0xbc, 0xc0, 0x71, 0xcd, 0x3b, 0xfd, 0x9a, 0x32, 0x19, 0x7e, 0xeb, 0x8a, 0xa7,
207 +             0x6e, 0xd4, 0xac, 0xcb, 0x59, 0xc2, 0x54, 0x26, 0xc6, 0xab, 0x71, 0xc7, 0xc3, 0x72,
208 +             0xc, 0xa9, 0xad, 0xa4, 0xad, 0x8c, 0x9e, 0x35, 0x7b, 0x4c, 0x5d, 0xc7, 0x66, 0x12,
209 +             0x8a, 0xc5, 0x42, 0x89, 0xc1, 0x77, 0x32, 0xdc, 0xe8, 0x4b, 0x51, 0x31, 0x30, 0x3,
210 +             0x20, 0xe3, 0xb6, 0x8c, 0xbb, 0xab, 0xe8, 0x89, 0xf8, 0xed, 0xac, 0x6d, 0x8e, 0xb1,
211 ~             0x83, 0xe8, 0x92, 0x18, 0x28, 0x70, 0x1e, 0x81, 0x76, 0x56, 0xb6, 0x15];
    |

Check warning on line 316 in components/zcash_address/src/kind/unified/fvk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

useless use of `vec!` 

warning: useless use of `vec!`
   --> components/zcash_address/src/kind/unified/fvk.rs:309:23
    |
309 |           let encoded = vec![
    |  _______________________^
310 | |             0xc4, 0x70, 0xc8, 0x7a, 0xcc, 0xe6, 0x6b, 0x1a, 0x62, 0xc7, 0xcd, 0x5f, 0x76, 0xd8,
311 | |             0xcc, 0x9c, 0x50, 0xbd, 0xce, 0x85, 0x80, 0xd7, 0x78, 0x25, 0x3e, 0x47, 0x9, 0x57,
312 | |             0x7d, 0x6a, 0xdb, 0x10, 0xb4, 0x11, 0x80, 0x13, 0x4c, 0x83, 0x76, 0xb4, 0x6b, 0xbd,
...   |
315 | |             0xf4, 0xf5, 0x16, 0xef, 0x5c, 0xe0, 0x26, 0xbc, 0x23, 0x73, 0x76, 0x3f, 0x4b,
316 | |         ];
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
help: you can use an array directly
    |
309 ~         let encoded = [0xc4, 0x70, 0xc8, 0x7a, 0xcc, 0xe6, 0x6b, 0x1a, 0x62, 0xc7, 0xcd, 0x5f, 0x76, 0xd8,
310 +             0xcc, 0x9c, 0x50, 0xbd, 0xce, 0x85, 0x80, 0xd7, 0x78, 0x25, 0x3e, 0x47, 0x9, 0x57,
311 +             0x7d, 0x6a, 0xdb, 0x10, 0xb4, 0x11, 0x80, 0x13, 0x4c, 0x83, 0x76, 0xb4, 0x6b, 0xbd,
312 +             0xef, 0x83, 0x5c, 0xa7, 0x68, 0xe6, 0xba, 0x41, 0x12, 0xbd, 0x43, 0x24, 0xf5, 0xaa,
313 +             0xa0, 0xf5, 0xf8, 0xe1, 0x59, 0xa0, 0x95, 0x85, 0x86, 0xf1, 0x9e, 0xcf, 0x8f, 0x94,
314 ~             0xf4, 0xf5, 0x16, 0xef, 0x5c, 0xe0, 0x26, 0xbc, 0x23, 0x73, 0x76, 0x3f, 0x4b];
    |

Check warning on line 287 in components/zcash_address/src/kind/unified/fvk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

useless use of `vec!` 

warning: useless use of `vec!`
   --> components/zcash_address/src/kind/unified/fvk.rs:279:48
    |
279 |           let truncated_after_sapling_typecode = vec![
    |  ________________________________________________^
280 | |             0xac, 0x26, 0x5b, 0x19, 0x8f, 0x88, 0xb0, 0x7, 0xb3, 0x0, 0x91, 0x19, 0x52, 0xe1, 0x73,
281 | |             0x48, 0xff, 0x66, 0x7a, 0xef, 0xcf, 0x57, 0x9c, 0x65, 0xe4, 0x6a, 0x7a, 0x1d, 0x19,
282 | |             0x75, 0x6b, 0x43, 0xdd, 0xcf, 0xb9, 0x9a, 0xf3, 0x7a, 0xf8, 0xb, 0x23, 0x96, 0x64,
...   |
286 | |             0x54, 0xd1, 0x9e, 0xec, 0x8b, 0xef, 0x35, 0xb8, 0x44, 0xdd, 0xab, 0x9a, 0x8d,
287 | |         ];
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
help: you can use an array directly
    |
279 ~         let truncated_after_sapling_typecode = [0xac, 0x26, 0x5b, 0x19, 0x8f, 0x88, 0xb0, 0x7, 0xb3, 0x0, 0x91, 0x19, 0x52, 0xe1, 0x73,
280 +             0x48, 0xff, 0x66, 0x7a, 0xef, 0xcf, 0x57, 0x9c, 0x65, 0xe4, 0x6a, 0x7a, 0x1d, 0x19,
281 +             0x75, 0x6b, 0x43, 0xdd, 0xcf, 0xb9, 0x9a, 0xf3, 0x7a, 0xf8, 0xb, 0x23, 0x96, 0x64,
282 +             0x8c, 0x57, 0x56, 0x67, 0x9, 0x40, 0x35, 0xcb, 0xb1, 0xa4, 0x91, 0x4f, 0xdc, 0x39, 0x0,
283 +             0x98, 0x56, 0xa8, 0xf7, 0x25, 0x1a, 0xc8, 0xbc, 0xd7, 0xb3, 0xb0, 0xfa, 0x78, 0x6,
284 +             0xe8, 0x50, 0xfe, 0x92, 0xec, 0x5b, 0x1f, 0x74, 0xb9, 0xcf, 0x1f, 0x2e, 0x3b, 0x41,
285 ~             0x54, 0xd1, 0x9e, 0xec, 0x8b, 0xef, 0x35, 0xb8, 0x44, 0xdd, 0xab, 0x9a, 0x8d];
    |

Check warning on line 240 in components/zcash_address/src/kind/unified/fvk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

useless use of `vec!` 

warning: useless use of `vec!`
   --> components/zcash_address/src/kind/unified/fvk.rs:231:33
    |
231 |           let truncated_padding = vec![
    |  _________________________________^
232 | |             0xdf, 0xea, 0x84, 0x55, 0xc3, 0x4a, 0x7c, 0x6e, 0x9f, 0x83, 0x3, 0x21, 0x14, 0xb0,
233 | |             0xcf, 0xb0, 0x60, 0x84, 0x75, 0x3a, 0xdc, 0xb9, 0x93, 0x16, 0xc0, 0x8f, 0x28, 0x5f,
234 | |             0x61, 0x5e, 0xf0, 0x8e, 0x44, 0xae, 0xa6, 0x74, 0xc5, 0x64, 0xad, 0xfa, 0xdc, 0x7d,
...   |
239 | |             0x43, 0x8e, 0xc0, 0x3e, 0x9f, 0xf4, 0xf1, 0x80, 0x32, 0xcf, 0x2f, 0x7e, 0x7f, 0x91,
240 | |         ];
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
help: you can use an array directly
    |
231 ~         let truncated_padding = [0xdf, 0xea, 0x84, 0x55, 0xc3, 0x4a, 0x7c, 0x6e, 0x9f, 0x83, 0x3, 0x21, 0x14, 0xb0,
232 +             0xcf, 0xb0, 0x60, 0x84, 0x75, 0x3a, 0xdc, 0xb9, 0x93, 0x16, 0xc0, 0x8f, 0x28, 0x5f,
233 +             0x61, 0x5e, 0xf0, 0x8e, 0x44, 0xae, 0xa6, 0x74, 0xc5, 0x64, 0xad, 0xfa, 0xdc, 0x7d,
234 +             0x64, 0x2a, 0x9, 0x47, 0x16, 0xf6, 0x5d, 0x8e, 0x46, 0xc4, 0xf0, 0x54, 0xfa, 0x5, 0x28,
235 +             0x1e, 0x3d, 0x7d, 0x37, 0xa5, 0x9f, 0x8b, 0x62, 0x78, 0xf6, 0x50, 0x18, 0x63, 0xe4,
236 +             0x51, 0x14, 0xae, 0x89, 0x41, 0x86, 0xd4, 0x9f, 0x10, 0x4b, 0x66, 0x2b, 0xf9, 0x46,
237 +             0x9c, 0xeb, 0xe8, 0x90, 0x8, 0xad, 0xd9, 0x6c, 0x6a, 0xf1, 0xed, 0xeb, 0x72, 0x44,
238 ~             0x43, 0x8e, 0xc0, 0x3e, 0x9f, 0xf4, 0xf1, 0x80, 0x32, 0xcf, 0x2f, 0x7e, 0x7f, 0x91];
    |

Check warning on line 222 in components/zcash_address/src/kind/unified/fvk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

useless use of `vec!` 

warning: useless use of `vec!`
   --> components/zcash_address/src/kind/unified/fvk.rs:213:31
    |
213 |           let invalid_padding = vec![
    |  _______________________________^
214 | |             0x6b, 0x32, 0x44, 0xf1, 0xb, 0x67, 0xe9, 0x8f, 0x6, 0x57, 0xe3, 0x5, 0x17, 0xa0, 0x7,
215 | |             0x5c, 0xb0, 0xc9, 0x23, 0xcc, 0xb7, 0x54, 0xac, 0x55, 0x6a, 0x65, 0x99, 0x95, 0x32,
216 | |             0x97, 0xd5, 0x34, 0xa7, 0xc8, 0x6f, 0xc, 0xd7, 0x3b, 0xe0, 0x88, 0x19, 0xf3, 0x3e,
...   |
221 | |             0xdf, 0x63, 0xe7, 0xef, 0x65, 0x6b, 0x18, 0x23, 0xf7, 0x3e, 0x35, 0x7c, 0xf3, 0xc4,
222 | |         ];
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
help: you can use an array directly
    |
213 ~         let invalid_padding = [0x6b, 0x32, 0x44, 0xf1, 0xb, 0x67, 0xe9, 0x8f, 0x6, 0x57, 0xe3, 0x5, 0x17, 0xa0, 0x7,
214 +             0x5c, 0xb0, 0xc9, 0x23, 0xcc, 0xb7, 0x54, 0xac, 0x55, 0x6a, 0x65, 0x99, 0x95, 0x32,
215 +             0x97, 0xd5, 0x34, 0xa7, 0xc8, 0x6f, 0xc, 0xd7, 0x3b, 0xe0, 0x88, 0x19, 0xf3, 0x3e,
216 +             0x26, 0x19, 0xd6, 0x5f, 0x9a, 0x62, 0xc9, 0x6f, 0xad, 0x3b, 0xe5, 0xdd, 0xf1, 0xff,
217 +             0x5b, 0x4a, 0x13, 0x61, 0xc0, 0xd5, 0xa5, 0x87, 0xc5, 0x69, 0x48, 0xdb, 0x7e, 0xc6,
218 +             0x4e, 0xb0, 0x55, 0x41, 0x3f, 0xc0, 0x53, 0xbb, 0x79, 0x8b, 0x24, 0xa0, 0xfa, 0xd1,
219 +             0x6e, 0xea, 0x9, 0xea, 0xb3, 0xaf, 0x0, 0x7d, 0x86, 0x47, 0xdb, 0x8b, 0x38, 0xdd, 0x7b,
220 ~             0xdf, 0x63, 0xe7, 0xef, 0x65, 0x6b, 0x18, 0x23, 0xf7, 0x3e, 0x35, 0x7c, 0xf3, 0xc4];
    |

Check warning on line 303 in components/zcash_address/src/kind/unified/address.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

useless use of `vec!` 

warning: useless use of `vec!`
   --> components/zcash_address/src/kind/unified/address.rs:299:23
    |
299 |           let encoded = vec![
    |  _______________________^
300 | |             0xf0, 0x9e, 0x9d, 0x6e, 0xf5, 0xa6, 0xac, 0x16, 0x50, 0xf0, 0xdb, 0xe1, 0x2c, 0xa5,
301 | |             0x36, 0x22, 0xa2, 0x04, 0x89, 0x86, 0xe9, 0x6a, 0x9b, 0xf3, 0xff, 0x6d, 0x2f, 0xe6,
302 | |             0xea, 0xdb, 0xc5, 0x20, 0x62, 0xf9, 0x6f, 0xa9, 0x86, 0xcc,
303 | |         ];
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
    = note: `-W clippy::useless-vec` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::useless_vec)]`
help: you can use an array directly
    |
299 ~         let encoded = [0xf0, 0x9e, 0x9d, 0x6e, 0xf5, 0xa6, 0xac, 0x16, 0x50, 0xf0, 0xdb, 0xe1, 0x2c, 0xa5,
300 +             0x36, 0x22, 0xa2, 0x04, 0x89, 0x86, 0xe9, 0x6a, 0x9b, 0xf3, 0xff, 0x6d, 0x2f, 0xe6,
301 ~             0xea, 0xdb, 0xc5, 0x20, 0x62, 0xf9, 0x6f, 0xa9, 0x86, 0xcc];
    |

Check warning on line 9 in components/zcash_address/src/kind/unified/address/test_vectors.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

fields `root_seed`, `account`, and `diversifier_index` are never read 

warning: fields `root_seed`, `account`, and `diversifier_index` are never read
  --> components/zcash_address/src/kind/unified/address/test_vectors.rs:9:9
   |
1  | pub struct TestVector {
   |            ---------- fields in this struct
...
9  |     pub root_seed: Vec<u8>,
   |         ^^^^^^^^^
10 |     pub account: u32,
   |         ^^^^^^^
11 |     pub diversifier_index: u32,
   |         ^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 4 in ironfish-primitives/benches/note_decryption.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `ff::Field` 

warning: unused import: `ff::Field`
 --> ironfish-primitives/benches/note_decryption.rs:4:5
  |
4 | use ff::Field;
  |     ^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Check failure on line 47 in ironfish-primitives/benches/note_decryption.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

failed to resolve: use of undeclared crate or module `jubjub` 

error[E0433]: failed to resolve: use of undeclared crate or module `jubjub`
  --> ironfish-primitives/benches/note_decryption.rs:47:25
   |
47 |             randomness: jubjub::Fr::random(&mut rng),
   |                         ^^^^^^ use of undeclared crate or module `jubjub`
   |
help: consider importing this struct
   |
1  + use ironfish_jubjub::Fr;
   |
help: if you import `Fr`, refer to it directly
   |
47 -             randomness: jubjub::Fr::random(&mut rng),
47 +             randomness: Fr::random(&mut rng),
   |

Check failure on line 33 in ironfish-primitives/benches/note_decryption.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

failed to resolve: use of undeclared crate or module `jubjub` 

error[E0433]: failed to resolve: use of undeclared crate or module `jubjub`
  --> ironfish-primitives/benches/note_decryption.rs:33:34
   |
33 |     let invalid_ivk = SaplingIvk(jubjub::Fr::random(&mut rng));
   |                                  ^^^^^^ use of undeclared crate or module `jubjub`
   |
help: consider importing this struct
   |
1  + use ironfish_jubjub::Fr;
   |
help: if you import `Fr`, refer to it directly
   |
33 -     let invalid_ivk = SaplingIvk(jubjub::Fr::random(&mut rng));
33 +     let invalid_ivk = SaplingIvk(Fr::random(&mut rng));
   |

Check failure on line 32 in ironfish-primitives/benches/note_decryption.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

failed to resolve: use of undeclared crate or module `jubjub` 

error[E0433]: failed to resolve: use of undeclared crate or module `jubjub`
  --> ironfish-primitives/benches/note_decryption.rs:32:32
   |
32 |     let valid_ivk = SaplingIvk(jubjub::Fr::random(&mut rng));
   |                                ^^^^^^ use of undeclared crate or module `jubjub`
   |
help: consider importing this struct
   |
1  + use ironfish_jubjub::Fr;
   |
help: if you import `Fr`, refer to it directly
   |
32 -     let valid_ivk = SaplingIvk(jubjub::Fr::random(&mut rng));
32 +     let valid_ivk = SaplingIvk(Fr::random(&mut rng));
   |

Check failure on line 8 in ironfish-primitives/benches/note_decryption.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

failed to resolve: use of undeclared crate or module `zcash_primitives` 

error[E0433]: failed to resolve: use of undeclared crate or module `zcash_primitives`
 --> ironfish-primitives/benches/note_decryption.rs:8:5
  |
8 | use zcash_primitives::{
  |     ^^^^^^^^^^^^^^^^ use of undeclared crate or module `zcash_primitives`

Check warning on line 515 in ironfish-primitives/src/zip32.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the following explicit lifetimes could be elided: 'a 

warning: the following explicit lifetimes could be elided: 'a
   --> ironfish-primitives/src/zip32.rs:515:6
    |
515 | impl<'a> From<&'a ExtendedSpendingKey> for ExtendedFullViewingKey {
    |      ^^        ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
515 - impl<'a> From<&'a ExtendedSpendingKey> for ExtendedFullViewingKey {
515 + impl From<&ExtendedSpendingKey> for ExtendedFullViewingKey {
    |

Check warning on line 718 in ironfish-primitives/src/transaction/mod.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> ironfish-primitives/src/transaction/mod.rs:718:18
    |
718 |             .zip(v_output_proofs.into_iter())
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `v_output_proofs`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/0277061b9a4096437b9b35f471c915e1cbe3128f/library/core/src/iter/traits/iterator.rs:589:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 708 in ironfish-primitives/src/transaction/mod.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> ironfish-primitives/src/transaction/mod.rs:708:26
    |
708 |                     .zip(v_spend_auth_sigs.into_iter()),
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `v_spend_auth_sigs`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/0277061b9a4096437b9b35f471c915e1cbe3128f/library/core/src/iter/traits/iterator.rs:589:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 63 in ironfish-primitives/src/transaction/util/sha256d.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits 

warning: the borrowed expression implements the required traits
  --> ironfish-primitives/src/transaction/util/sha256d.rs:63:28
   |
63 |         self.hasher.update(&buf);
   |                            ^^^^ help: change this to: `buf`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 516 in ironfish-primitives/src/transaction/txid.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this expression borrows a value the compiler would automatically borrow 

warning: this expression borrows a value the compiler would automatically borrow
   --> ironfish-primitives/src/transaction/txid.rs:516:9
    |
516 |         (&mut personal[..12]).copy_from_slice(ZCASH_AUTH_PERSONALIZATION_PREFIX);
    |         ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `personal[..12]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 371 in ironfish-primitives/src/transaction/txid.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this expression borrows a value the compiler would automatically borrow 

warning: this expression borrows a value the compiler would automatically borrow
   --> ironfish-primitives/src/transaction/txid.rs:371:5
    |
371 |     (&mut personal[..12]).copy_from_slice(ZCASH_TX_PERSONALIZATION_PREFIX);
    |     ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `personal[..12]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 90 in ironfish-primitives/src/transaction/txid.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this expression borrows a value the compiler would automatically borrow 

warning: this expression borrows a value the compiler would automatically borrow
  --> ironfish-primitives/src/transaction/txid.rs:90:9
   |
90 |         (&mut h).write_u32::<LittleEndian>(t_in.sequence).unwrap();
   |         ^^^^^^^^ help: change this to: `h`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 255 in ironfish-primitives/src/transaction/sighash_v4.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this expression borrows a value the compiler would automatically borrow 

warning: this expression borrows a value the compiler would automatically borrow
   --> ironfish-primitives/src/transaction/sighash_v4.rs:255:21
    |
255 |                     (&mut data)
    |                     ^^^^^^^^^^^ help: change this to: `data`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 231 in ironfish-primitives/src/transaction/sighash_v4.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this `map_or` can be simplified 

warning: this `map_or` can be simplified
   --> ironfish-primitives/src/transaction/sighash_v4.rs:229:18
    |
229 |                   !tx.sapling_bundle
    |  __________________^
230 | |                     .as_ref()
231 | |                     .map_or(true, |b| b.shielded_outputs.is_empty()),
    | |____________________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
help: use is_none_or instead
    |
229 ~                 !tx.sapling_bundle
230 ~                     .as_ref().is_none_or(|b| b.shielded_outputs.is_empty()),
    |
View more details on GitHub Actions