-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub field for Ridolfi Fellow project #1616
Closed
Closed
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c5d2280
Add files via upload
peterridolfi a8863cf
Add files via upload
peterridolfi 8ff0d9c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b170e14
Apply suggestions from code review
henryiii 7e408c2
fix: scale image down
henryiii 760262d
Apply suggestions from code review
henryiii 5a88817
Added git-hub repo link
peterridolfi 950f6ce
add git repo link and proposal
peterridolfi a7393c5
Merge branch 'master' into master
rct225 f48bca0
Merge remote-tracking branch 'origin/master' into peterridolfi/master
matthewfeickert 9e16107
Merge branch 'master' into peterridolfi/master
matthewfeickert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,9 +15,7 @@ e-mail: [email protected] | |
| project_title: Designing and implementing a converting tool for statistical models between pyhf and CMS combine | ||
| project_goal: > | ||
| The main goal of this project is to develop a tool that actively identifies and accommodates similarities and nuances between pyhf and CMS Combine models. The tool must be able to convert the given parameters form one type of model to the other type, while maintaining a high degree of accuracy between the actual functionality and predictions that are made by the models. Additionally, the tool should be able to give feedback concerning expected differences in these outputs based on the parameters that are given, and the limitations of the tool itself. Ultimately, the tool will serve as another method for better understanding the models that are created and the predictions that they make. | ||
| <br> | ||
| GitHub url: <a href="https://github.com/peterridolfi/Pyhf-to-Combine-converter.git">https://github.com/peterridolfi/Pyhf-to-Combine-converter.git</a> | ||
| focus-area: as | ||
| git-hub url: https://github.com/peterridolfi/Pyhf-to-Combine-converter.git | ||
| mentors: | ||
| - Matthew Feickert (University of Wisconsin-Madison) | ||
| - Alexander Held (University of Wisconsin-Madison) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. @henryiii @rct225 from https://iris-hep.org/docs/fellow it doesn't look like there is any schema field for a project URL. Do we not support this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthewfeickert We do have github-username, which we present as their GitHub repo on their page. I suppose we can add a field to the project for project-urls. I prefer "project-url" since some people are using gitlab as well as GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay well sounds like it isn't something that is currently supported in the spec so I'll make an Issue from this and close this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be best for now. The "url" under the presentation section is generally for the slides used during their talk, similar to what we do for IRIS-HEP member presentations and talks.