Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable libyaml GCC unused-value warning temporarily #14579

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Disable libyaml GCC unused-value warning temporarily #14579

merged 1 commit into from
Aug 4, 2023

Conversation

hcindyl
Copy link
Contributor

@hcindyl hcindyl commented Aug 4, 2023 •
edited
Loading

A Fix is proposed upstream and pending review.

ci_extra: build_test_all_windows

@hcindyl
Disable libyaml GCC unused-value warning temporarily
0c27576 
A Fix is proposed upstream and pending review.
@hcindyl
Copy link
Contributor Author

hcindyl commented Aug 4, 2023 •
edited
Loading

It is an outstanding issue at yaml/libyaml#210. I proposed the fix, but since the last commit for that project was 21 months ago, I am not sure when the change will be landed upstream.

We can also fork libyaml under iree-org or just sync .gitmodules to that commit. Really appreciate some advises on the approach.

benvanik
benvanik approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@benvanik benvanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the upstream patch is useful and I think the workaround as you have it here is fine until/if it ever lands. Thanks for doing that!

@hcindyl
Copy link
Contributor Author

hcindyl commented Aug 4, 2023

For #14507

@hcindyl hcindyl marked this pull request as ready for review August 4, 2023 20:31
@hcindyl hcindyl added the infrastructure Relating to build systems, CI, or testing label Aug 4, 2023
@hcindyl hcindyl merged commit 9643b0f into iree-org:main Aug 4, 2023
@hcindyl hcindyl deleted the gcc_libyaml-warning branch August 4, 2023 20:33
nhasabni pushed a commit to plaidml/iree that referenced this pull request Aug 24, 2023
@hcindyl @nhasabni
Disable libyaml GCC unused-value warning temporarily (iree-org#14579)
0868f8f 
A Fix is proposed upstream and pending review.

ci_extra: build_test_all_windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benvanik benvanik benvanik approved these changes

@ScottTodd ScottTodd Awaiting requested review from ScottTodd ScottTodd is a code owner

@stellaraccident stellaraccident Awaiting requested review from stellaraccident stellaraccident is a code owner

Assignees
No one assigned
Labels
infrastructure Relating to build systems, CI, or testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcindyl @benvanik