Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KeytoolSigner #1513

Closed
wants to merge 12 commits into from
Closed

Add KeytoolSigner #1513

wants to merge 12 commits into from

Conversation

UMR1352
Copy link
Contributor

@UMR1352 UMR1352 commented Jan 30, 2025

Description of change

Add KeytoolSigner, a Signer implementation that leverages IOTA Keytool CLI utility.

Links to any relevant issues

Closes issue #1468.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Added integration tests.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@UMR1352 UMR1352 added Enhancement New feature or improvement to an existing feature Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Jan 30, 2025
@UMR1352 UMR1352 self-assigned this Jan 30, 2025
@UMR1352 UMR1352 requested a review from a team as a code owner January 30, 2025 13:14
@UMR1352
Copy link
Contributor Author

UMR1352 commented Feb 3, 2025

See #1515. 1 PR for both WASM and Rust KeytoolSigner.

@UMR1352 UMR1352 closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@UMR1352 UMR1352

Labels
Added A new feature that requires a minor release. Part of "Added" section in changelog Enhancement New feature or improvement to an existing feature Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@UMR1352