WASM implementation of adapters' traits on WASM types #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MoveType has been moved from identity_iota_core to identity_iota_interaction * The identity_iota_interaction README has been updated to use the latest draft for folder and crate names
…iota_interaction::...`
…lpha # Conflicts: # identity_iota_core/Cargo.toml # identity_iota_core/src/rebased/iota/well_known_networks.rs
…ta_core/rebase version
…ta_core for the redesigned crate structure
* Compiling identity_iota_core for wasm32 will result in one compiler error
due to missing wasm-bindings for ProgrammableTransaction
(TODO in identity_iota_core/src/rebased/transaction.rs)
* identity_iota_core and examples are compilable for non wasm32 platforms
* Remaining compiler warnings should be investigated
* identity_iota_core e2e tests are compilable but will fail due to serialization/deserialization issues.
For example:
IotaTransactionBlockResponse bcs deserialization failed: NotSupported("deserialize_any")
thread 'identity::adding_controller_works' panicked at /home/christof/Develop/iotaledger/identity.rs/identity_iota_core/src/rebased/transaction.rs:84:14:
IotaTransactionBlockResponse bcs deserialization failed: NotSupported("deserialize_any")
stack backtrace:
0: rust_begin_unwind
1: core::panicking::panic_fmt
2: core::result::unwrap_failed
3: <identity_iota_core::rebased::transaction::TransactionOutput<T> as core::convert::From<identity_iota_core::rebased::transaction::TransactionOutputInternal<T>>>::from
4: <T as identity_iota_core::rebased::transaction::Transaction>::execute_with_opt_gas::{{closure}}
5: identity_iota_core::rebased::transaction::Transaction::execute::{{closure}}
6: e2e::identity::adding_controller_works::{{closure}}
7: tokio::runtime::scheduler::current_thread::CurrentThread::block_on
8: tokio::runtime::runtime::Runtime::block_on
9: e2e::identity::adding_controller_works
10: core::ops::function::FnOnce::call_once
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
…ialization BCS deserialization is not available for IotaTransactionBlockResponse because the BCS format is not self describing and several struct fields of IotaTransactionBlockResponse are optionally skipped during serialization. JSON deserialization will probably be available but using a cloned instance to convert a TransactionOutputInternal into a TransactionOutput will have a much better efficiency.
…Credential All tests running successfully for the first time now
* Fix clippy error writing `&Vec` instead of `&[_]` involves a new object where a slice will do * allow error clippy::too_many_arguments
… from format checks
…nd identity_iota_interaction
…iles and add clippy + format steps for bindings/wasm/iota_interaction_ts
…s crate is processed as workspace member
… merged PR - identity_wasm rust toolchain set to "1.84.0"
…atform-agnostic-types-and-adapters
UMR1352
added
Wasm
wulfraem
approved these changes
Jan 23, 2025
wulfraem
requested changes
Jan 23, 2025
UMR1352
changed the base branch from
feat/wasm32-develop-alpha
to
feat/identity-rebased-alpha
…o feat/platform-agnostic-types-and-adapters
Removed superfluous @iota/iota-sdk dependency from iota_interaction_ts package
| } | ||
| } | ||
|
|
||
| impl IotaTransactionBlockResponseT for ManagedIotaTransactionBlockResponseAdapter { |
There was a problem hiding this comment.
Unfortunately there has already been a very similar looking implementation for IotaTransactionBlockResponseT in bindings/wasm/iota_interaction_ts/src/iota_client_ts_sdk.rs
There was a problem hiding this comment.
Ooof, removing the one I added then
chrisgitiota
approved these changes
Jan 24, 2025
wulfraem
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Implemented remaining adapter traits on WASM types.
Links to any relevant issues
Fixes issue #1444