Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement checking of domain variables against cell_measures #1089

Merged

Conversation

benjwadams
Copy link
Contributor

Implementation of 5.8 Domain Variables when checking against cell measures, conformance required 4/4 in CF 1.9 standard.

@benjwadams benjwadams requested a review from leilabbb June 4, 2024 21:03
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.65%. Comparing base (b3f1891) to head (e3486ad).
Report is 6 commits behind head on develop.

Files Patch % Lines
compliance_checker/cf/cf_1_9.py 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1089      +/-   ##
===========================================
- Coverage    81.68%   81.65%   -0.04%     
===========================================
  Files           25       25              
  Lines         5226     5227       +1     
  Branches      1255     1257       +2     
===========================================
- Hits          4269     4268       -1     
- Misses         646      648       +2     
  Partials       311      311              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjwadams benjwadams merged commit d657152 into ioos:develop Jul 30, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant