Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NCEI downstream plugin test #1072

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented May 22, 2024

We thought that ioos/cc-plugin-ncei#52 would break this test here but it turns out we are not testing this plugin. Maybe we don't need it anymore? Do you know why we don't have it here @benjwadams?

Anyway, the NCEI plugin has an upstream test and should pass here as well. Let's try...

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.91%. Comparing base (ed9f59b) to head (21364f9).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1072      +/-   ##
===========================================
- Coverage    82.03%   81.91%   -0.13%     
===========================================
  Files           24       24              
  Lines         5178     5171       -7     
  Branches      1247     1237      -10     
===========================================
- Hits          4248     4236      -12     
- Misses         631      634       +3     
- Partials       299      301       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ocefpaf
Copy link
Member Author

ocefpaf commented May 22, 2024

Self-merging this one b/c it only adds a new plugin test.

@ocefpaf ocefpaf merged commit 5a5a7fe into ioos:develop May 22, 2024
25 of 26 checks passed
@ocefpaf ocefpaf deleted the run_ncei_plugin_test branch May 22, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant