skipif logic

ioos · Sep 23, 2021 · a456bcc · a456bcc
1 parent 7e37bf2
commit a456bcc
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/compliance_checker/tests/test_cli.py b/compliance_checker/tests/test_cli.py
@@ -219,20 +219,17 @@ def test_multi_checker_return_value(self, tmp_txt_file):
         assert not return_value
 
     def _check_libnetcdf_version():
-        try:
-            print("trying")
-            v = (
+        if platform.system() == "Linux":
+            # nc-config doesn't work on windows... and neither does NCZarr so this skipif is mutually exclusive to the OS check skipif
+            return (
                 float(
                     subprocess.check_output(
                         ["nc-config", "--version"], encoding="UTF-8"
                     )[9:12]
                 )
                 < 8.0
             )
-            print(v)
-            return v
-        except FileNotFoundError as e:
-            print(f"WARNING: {e}\nSkipping NCZarr tests")
+        else:
             return True
 
     # TODO uncomment the third parameter once S3 support is working