Use DiffEditor of monaco (fix for #2275 and #2260)
#2298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehmetoguzderin
changed the title
DiffEditor of monaco (fix for #2275)DiffEditor of monaco (fix for #2275 and #2260)
…oject#2302) Bumps [dockerflow](https://github.com/mozilla-services/python-dockerflow) from 2019.6.0 to 2019.9.0. - [Release notes](https://github.com/mozilla-services/python-dockerflow/releases) - [Changelog](https://github.com/mozilla-services/python-dockerflow/blob/master/docs/changelog.rst) - [Commits](mozilla-services/python-dockerflow@2019.6.0...2019.9.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
- add a few default pytest parameters that I use often - add flake8 linting - add coverage linting - add isort linting - add ability to disable flake8, coverage, isort with new --lean parameter for pytest - add staticfiles pytest plugin - restructure tests directory a bit to stop requiring sys.path modification - fix a warning that showed up because of freezegun
|
This looks great @mehmetoguzderin! I'm not sure why the unit tests are failing though. My only other comment is that the initial revision diff looks a little strange (it claims a line is deleted at the top): |
Thanks! It is strange indeed and have been noticed by others too: Maybe we can specialize in the initial revision to solve this after we fix the unit tests issue. |
…ct#2312) Bumps [pytest-mock](https://github.com/pytest-dev/pytest-mock) from 1.10.4 to 1.11.0. - [Release notes](https://github.com/pytest-dev/pytest-mock/releases) - [Changelog](https://github.com/pytest-dev/pytest-mock/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-mock@1.10.4...v1.11.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [pytest](https://github.com/pytest-dev/pytest) from 5.1.3 to 5.2.0. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest@5.1.3...5.2.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Fixes a console error by implicitly removing the dependency on react-side-effect (see nfl/react-helmet#465).
…ect#2314) Some URLs that people use can get quite long, so best to increase the max amount here.
1 task
Bumps [kombu](https://kombu.readthedocs.io) from 4.6.4 to 4.6.5. Signed-off-by: dependabot-preview[bot] <[email protected]>
|
@mehmetoguzderin do you want to try rebasing this against latest master? The monaco upgrade in #2273 may have either fixed this or made the test error output more intelligible, if we're lucky. |
This will let us reach out more easily to people who log into alpha.iodide.io. Standard Mozilla privacy policy still applies and GitHub will ensure that people consent to this.
) (iodide-project#2332) It should not be required for public projects like Iodide. Instead, import enough circle environment into our docker compose environment so uploads can complete successfully.
This reverts commit b9bc6e3.
This reverts commit 01028b7.
This reverts commit afb69c4.
This reverts commit 6746cca.
This reverts commit 7a551fc.
This reverts commit 8ceeb6b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to solve #2275 and #2260.
This pull request migrates generation of content for
revision-difffromReactDiffViewertoDiffEditorprovided bymonacoitself.revision-diff-contentserves as a non-redux wrapper for abstracting details ofmonacoaway. Further connections such as theming should be communicated as properties fromrevision-difftorevision-diff-contentin render function.