fix: routing compatibles encoding and resolve #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes logic and reverts #76 and makes my other PR #78 obsolete if this is merged.
Based on https://router.vuejs.org/guide/migration/#-route-properties-Encoding it looks like we shouldn't do additional encoding, and personally I think it would be better to leave it up to the router
resolve
when and where to encode.I tried to remove
any
where possible and fixed type issues based on the function usage.Linked Issues
Additional context
It's possible I have made bad assumptions about the types 😬 please let me know if this is the case.
Hopefully I can remove some of the exclusions/splits between the Vue 2 and Vue 3 routing in a future PR.