Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: routing compatibles encoding and resolve #79

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

BobbieGoede
Copy link
Member

Description

This PR changes logic and reverts #76 and makes my other PR #78 obsolete if this is merged.

Based on https://router.vuejs.org/guide/migration/#-route-properties-Encoding it looks like we shouldn't do additional encoding, and personally I think it would be better to leave it up to the router resolve when and where to encode.

I tried to remove any where possible and fixed type issues based on the function usage.

Linked Issues

Additional context

It's possible I have made bad assumptions about the types 😬 please let me know if this is the case.

Hopefully I can remove some of the exclusions/splits between the Vue 2 and Vue 3 routing in a future PR.

@BobbieGoede BobbieGoede force-pushed the refactor/routing-compatibles branch from 4a9de71 to a3e13c4 Compare November 2, 2023 12:57
@kazupon
Copy link
Member

kazupon commented Nov 4, 2023

Hopefully I can remove some of the exclusions/splits between the Vue 2 and Vue 3 routing in a future PR.

Yeah 😅

When I started the project for this package, I made nuxt i18n v8 to work with both Nuxt Bridge and Nuxt 3.

nuxt i18n v8 is currently only available for Nuxt 3.
And the composable for nuxt i18n v7.4 that @wattanx is working on targets the nuxt i18n v8 composables (useLocalePath and etc) to port.
I think that @intlify/routing should be integrated into nuxt v8 for maintenance reasons.

This integration should be a TODO for nuxt i18n v9 after the official release of nuxt i18n v8.

@kazupon kazupon added the bug Includes new features label Nov 4, 2023
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kazupon kazupon merged commit 98f08cb into intlify:main Nov 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Includes new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash in NuxtLink don't work with LocalePath LocalePath double encoding URLs, causing 404s
2 participants