Add support for includeFilenameInKey to address issue #336 #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue raised here - #336 by adding support for the
includeFilenameInKey
field in .eslintrc.js settings.This flag specifies if the filename (without the extension) should be considered as part of the message keys. This is only valid when localeKey is set to 'path'. For example, the key 'title' in the file 'common.json' would be considered to have key 'common.title' if this flag is set to true.
The only rule that this affected seemed to be
no-duplicate-keys-in-locale
- which I've addressed in this PR.Documentation and tests have been added.
If we can get this into a release soon that would be amazing for us as we use your eslint plugin extensively! Thanks so much for your work on this project & it was pretty easy to work on.