Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #360 package version shows on settings and main webui page #363

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

isc-hwojnick
Copy link
Contributor

package version now displays on the settings and main UI pages

Copy link
Collaborator

@isc-pbarton isc-pbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nitpick, otherwise looks great to me

@@ -224,4 +226,11 @@ ClassMethod GetSettingsURL(%request As %CSP.Request) As %SystemBase
quit {"url": (settingsURL)}
}

ClassMethod GetPackageVersion() As %SystemBase
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ClassMethod GetPackageVersion() As %SystemBase
ClassMethod GetPackageVersion() As %Library.DynamicObject

@isc-hwojnick isc-hwojnick requested a review from isc-pbarton June 17, 2024 15:50
@isc-hwojnick isc-hwojnick merged commit 33ed837 into main Jun 17, 2024
2 checks passed
@isc-hwojnick isc-hwojnick deleted the show-package-version branch June 17, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants