Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added baseline utility #348

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Conversation

isc-pbarton
Copy link
Collaborator

Resolves #338
Baseline export utility for now just includes classes and routines.

@isc-pbarton isc-pbarton requested a review from isc-tleavitt June 5, 2024 16:39
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicks and one more substantial comment re: generally avoiding mapped items.

set sc = $$$OK
try {
write !, "Exporting classes..."
set sql = "SELECT ID FROM %Dictionary.ClassDefinition"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend using %Library.RoutineMgr:StudioOpenDialog instead as it can filter out mapped items better.

cls/SourceControl/Git/Utils.cls Outdated Show resolved Hide resolved
cls/SourceControl/Git/Utils.cls Outdated Show resolved Hide resolved
@isc-pbarton isc-pbarton requested a review from isc-tleavitt June 6, 2024 20:31
@isc-tleavitt
Copy link
Collaborator

Good to merge once CI has passed.

@isc-pbarton isc-pbarton merged commit 59a04d9 into intersystems:main Jun 7, 2024
1 check passed
@isc-pbarton isc-pbarton deleted the baseline-export branch June 7, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to baseline code from an existing instance
2 participants