Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect IRIS-based Health* platforms correctly #149

Merged

Conversation

gjsjohnmurray
Copy link
Contributor

This PR fixes #141 by checking $zversion for "Cache" or "IRIS" prefix.

It also adds .vscode to .gitignore so contributors can use VS Code as their editor.

@nikitaeverywhere nikitaeverywhere merged commit 11418e0 into intersystems-community:master Jul 6, 2022
@nikitaeverywhere
Copy link
Member

Looks good!

Whenever you need a release, please draft a PR – I'll merge it too.

Regarding #148, yup, at the time of development there were not much we could to do set up automated testing or something, I wish we had it. So any release can potentially break things, and it's good if people report it, but many won't. In such cases, I would probably advice to revert & investigate.

When it comes to /terminalsocket, and classes /terminalsocket/ClassName.csp or something (I don't remember clearly), the class name after the application name was mandatory in some Ensemble versions. When I was actively working on a project I was testing it against Ensemble and Cache 2018 or so. Some "magic" things happen there, and it's good to have a few test instances installed when you fix core features. Literally, in that case, WebSocket wouldn't work if you don't use the full classname in the URL! I know it puts more work, but given these are installed should take just around 10 minutes to validate and potentially save hours or days for WebTerminal users.

Thanks a ton for your contributions!

@gjsjohnmurray gjsjohnmurray deleted the fix-141 branch July 6, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants