-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including DisGeNET converter #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments.
- please run checkstyleMain (I think you haven't, because e.g. copyright should be 2002-2020)
- I would move the contructor method up (first method)
- not sure about the constants GENE_LIST_FILE , what is used for? It's always empty, correct? so probably the processGeneList is never called....
…emoved gene list functionality
Thanks @danielabutano , I just made the suggested changes and some slight clean-up. Regarding the gene list part, this was a functionality to integrate the data only for a specific set of genes given in an input file, as that was useful for the specific use case for which this data converter was made originally. However this is probably not relevant for HumanMine and we'd prefer to integrate the data for all genes. |
Thanks @AdrianBZG ! I leave the merge to @sergiocontrino |
hi @AdrianBZG, i did change a few things for the humanmine build, mainly the key (from symbol to primaryid), but also some in the parsing, using directly the ncbi identifier and not the id resolver. unless you have other ideas, i'll make a PR to your repo first. thanks! |
thank you @AdrianBZG! i'll merge the pull request and then modify the code with the adaptations for humanmine. you can disregard the PR on your repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This pull requests aims at including the DisGeNET converter to the main set of converters for HumanMine. It optionally takes a gene list CSV file as input to only integrate data for a specific subset of human genes, but includes data for all genes in the DisGeNET data source if no list is given (default behaviour)