fix(background): clear sessions on page reload #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extension builds preview
|
){kind=icon}
){kind=icon}
sidvishnoi
commented
Jan 20, 2025
| await page.evaluate(() => { | ||
| window.addEventListener('monetization', monetizationCallback); | ||
| await page.addInitScript({ | ||
| content: `window.addEventListener('monetization', monetizationCallback)`, |
There was a problem hiding this comment.
addInitScript will be survive across page.reload and navigation (exposeFunction also survives such navigations), so we don't need to add listener again.
github-actions
bot
added
the
area: background
sidvishnoi
commented
Jan 20, 2025
This reverts commit 3d588a2.
sidvishnoi
changed the title
sidvishnoi
changed the title
raducristianpopa
approved these changes
Jan 21, 2025
|
|
||
| const walletAddressUrl = process.env.TEST_WALLET_ADDRESS_URL; | ||
|
|
||
| test.describe('should not pay immediately when overpaying', () => { |
There was a problem hiding this comment.
Spent the last couple of minutes looking for a test that goes through this flow without realizing that I already went through it. PEBCAK 🙄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #850
Reopens #819
Part of #610
Changes proposed in this pull request
Revert #831, add tests for page reload, sessions & overpaying, mark tests that were fixed by #831 as failing.