Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests/e2e): add toHaveStorage custom matcher & utils #812

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

sidvishnoi
Copy link
Member

Context

Remove duplication in tests related to background's storage.

Changes proposed in this pull request

  • Add custom matcher toHaveStorage for easy storage inspection in tests
  • Add helper getStorage as a type-safe and simpler wrapper over chrome.storage.keys.get
  • Update tests to use the custom matcher and helpers.

Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@github-actions github-actions bot added area: tests Improvements or additions to tests area: shared Changes to shared libraries and utilities labels Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Extension builds preview

Name Link
Latest commit 8075ccf
Latest job logs Run #12649910175
BadgeDownload
BadgeDownload

Copy link
Member

@DarianM DarianM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sidvishnoi sidvishnoi merged commit 8c28d38 into main Jan 8, 2025
11 checks passed
@sidvishnoi sidvishnoi deleted the e2e-test-storage-helper branch January 8, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: shared Changes to shared libraries and utilities area: tests Improvements or additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants