test(e2e): make timeouts shorter

So tests that are hanging flakily fail fast
interledger · Jan 24, 2025 · 4a6f7a9 · 4a6f7a9
1 parent c0fdfc8
commit 4a6f7a9
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 11 deletions.
diff --git a/playwright.config.ts b/playwright.config.ts
@@ -25,7 +25,11 @@ export default defineConfig({
       { open: 'never', outputFolder: path.join(testDir, 'playwright-report') },
     ],
   ],
-  use: { trace: 'retain-on-failure' },
+  use: {
+    trace: 'retain-on-failure',
+    actionTimeout: 8_000,
+    navigationTimeout: 10_000,
+  },
 
   projects: [
     {

diff --git a/tests/e2e/fixtures/base.ts b/tests/e2e/fixtures/base.ts
@@ -36,7 +36,7 @@ export const test = base.extend<{ page: Page }, BaseScopeWorker>({
       await use(context);
       await context.close();
     },
-    { scope: 'worker' },
+    { scope: 'worker', timeout: 5_000 },
   ],
 
   // This is the background service worker in Chrome, and background script
@@ -47,7 +47,7 @@ export const test = base.extend<{ page: Page }, BaseScopeWorker>({
       const background = await getBackground(browserName, context);
       await use(background);
     },
-    { scope: 'worker' },
+    { scope: 'worker', timeout: 5_000 },
   ],
 
   i18n: [
@@ -65,7 +65,7 @@ export const test = base.extend<{ page: Page }, BaseScopeWorker>({
       await use(popup);
       await popup.close();
     },
-    { scope: 'worker' },
+    { scope: 'worker', timeout: 5_000 },
   ],
 
   page: async ({ persistentContext: context }, use) => {

diff --git a/tests/e2e/fixtures/connected.ts b/tests/e2e/fixtures/connected.ts
@@ -22,7 +22,7 @@ export const test = base.extend<{ page: Page }, { popup: Popup }>({
 
       await disconnectWallet(popup);
     },
-    { scope: 'worker' },
+    { scope: 'worker', timeout: 10_000 },
   ],
 });
 

diff --git a/tests/e2e/pages/popup.ts b/tests/e2e/pages/popup.ts
@@ -55,18 +55,22 @@ export async function fillPopup(
   i18n: BrowserIntl,
   params: Partial<ConnectDetails>,
 ) {
+  const timeout = 1000;
   const fields = getPopupFields(popup, i18n);
   if (typeof params.walletAddressUrl !== 'undefined') {
-    await fields.walletAddressUrl.fill(params.walletAddressUrl);
-    await fields.walletAddressUrl.blur();
+    await fields.walletAddressUrl.fill(params.walletAddressUrl, { timeout });
+    await fields.walletAddressUrl.blur({ timeout });
   }
   if (typeof params.amount !== 'undefined') {
-    await fields.amount.fill(params.amount);
-    await fields.amount.blur();
+    await fields.amount.fill(params.amount, { timeout });
+    await fields.amount.blur({ timeout });
   }
   if (typeof params.recurring !== 'undefined') {
-    await fields.recurring.setChecked(params.recurring, { force: true });
-    await fields.recurring.blur();
+    await fields.recurring.setChecked(params.recurring, {
+      force: true,
+      timeout,
+    });
+    await fields.recurring.blur({ timeout });
   }
 
   return fields.connectButton;
-Original file line number
+Diff line change
@@ Expand Up @@
           await disconnectWallet(popup);
         },
-        { scope: 'worker' },
+        { scope: 'worker', timeout: 10_000 },
       ],
     });
@@ Expand Down @@