feat(backend): tenanted webhooks #3317
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: tests
golobitch
force-pushed
the
feature/tenant-settings-initial
branch
4 times, most recently
from
6ee3c75 to
12d1318
Compare
Base automatically changed from
feature/tenant-settings-initial
to
2893/multi-tenancy-v1
February 24, 2025 22:48
njlie
force-pushed
the
nl/3121/tenanted-webhooks
branch
from
e6b9736 to
792d0b3
Compare
njlie
requested review from
BlairCurrey,
mkurapov,
golobitch,
sanducb and
oana-lolea
2 tasks
njlie
commented
Feb 26, 2025
| @@ -68,7 +68,8 @@ export class Peer | |||
| }, | |||
| liquidityThreshold: this.liquidityThreshold, | |||
| balance | |||
| } | |||
| }, | |||
| tenantId // TODO: update when peers are tenanted | |||
There was a problem hiding this comment.
For now this is using the operator tenant ID, but will be replaced with the peer's own tenant id once #3129 is merged in.
|
Large portions of this code are reviewable, but at the moment there are a handful of sections that have temporary code to address the fact that peers are not tenanted - as they may generate a |
BlairCurrey
reviewed
Mar 6, 2025
| body, | ||
| { | ||
| timeout: settings?.webhookTimeout?.value | ||
| ? Number(settings?.webhookTimeout?.value) |
There was a problem hiding this comment.
Should handle the case where Number(settings?.webhookTimeout?.value) resolves to NaN (eg value is "a").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
Fixes #3121.
Checklist
fixes #numberuser-docslabel (if necessary)