feat(profiles_links): add profiles links for older FR agents #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Traces to profiles links currently aren't supported for or older versions of the FusionReactor agent. The exported profiles don't contain the info/ID of the linked span and the exported spans don't contain the
pyroscope.profile.id
attribute/tag which Grafana uses to identify a traces-to-profiles link.Solution:
pid
attribute to identify a linked profile instead, Grafana could use this to create a link to the profile.txnId
as a tag, in place ofpyroscope.profile.id
, within the trace to profiles section for the query to find the associated profile.createSpanLink.tsx
andlinks.ts
changed to handle adding the profiles link button. Changed query seems to be defined in Tempo's resultTransformer.ts.index.tsx
andSpanFlameGraph.tsx
changed to handle adding the flame graph to span.