Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiles_links): add profiles links for older FR agents #31

Open
wants to merge 2 commits into
base: v11.3.x
Choose a base branch
from

Conversation

LMarkie
Copy link

@LMarkie LMarkie commented Jan 16, 2025

Issue:
Traces to profiles links currently aren't supported for or older versions of the FusionReactor agent. The exported profiles don't contain the info/ID of the linked span and the exported spans don't contain the pyroscope.profile.id attribute/tag which Grafana uses to identify a traces-to-profiles link.

Solution:

  • The spans have a pid attribute to identify a linked profile instead, Grafana could use this to create a link to the profile.
  • The span selector needs to be removed due to the profiles missing the span info.
  • The Tempo datasource needs to be configured to use txnId as a tag, in place of pyroscope.profile.id, within the trace to profiles section for the query to find the associated profile.

createSpanLink.tsx and links.ts changed to handle adding the profiles link button. Changed query seems to be defined in Tempo's resultTransformer.ts.

index.tsx and SpanFlameGraph.tsx changed to handle adding the flame graph to span.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant