Fix null reference timing problem in Chrome #263
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enorfelt
approved these changes
Jan 27, 2025
|
@codehippie1 could you please take a look at this? :) |
|
Merged |
|
I will release this with an upgrade to Angular 19, working on merging a PR for 19. |
|
Will it be compatible with Angular 18? |
|
Or could you release a patch version in 18? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix done in #44 causes problems reported in #259.
I haven't dug deep into the firefox problem that should have been fixed by the change, but it does cause problems in Chrome and maybe other browsers.
document-viewer.component.ts:18 TypeError: Cannot read properties of null (reading 'location')Seems to be a timing problem, because setting the src after the component is loaded does not cause the error. As the code worked fine in chrome before the change I made a combination that should fix both problems.