fix: bump xml2js to 0.6.2 #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blimmer
commented
Apr 18, 2024
| @@ -55,7 +55,7 @@ | |||
| "@types/mock-fs": "^4.13.0", | |||
| "@types/node": "^14.14.41", | |||
| "@types/uuid": "^8.3.0", | |||
| "@types/xml2js": "^0.4.8", | |||
| "@types/xml2js": "^0.4.14", | |||
There was a problem hiding this comment.
This is the latest version of the types package.
blimmer
commented
Apr 18, 2024
| @@ -77,7 +77,7 @@ | |||
| "striptags": "^3.1.1", | |||
| "uuid": "^8.3.2", | |||
| "winston": "^3.3.3", | |||
| "xml2js": "^0.4.23", | |||
| "xml2js": "^0.6.2", | |||
There was a problem hiding this comment.
The vulnerability was technically fixed in 0.5.x, but it broke the .hasOwnProperty prototype method you're using in this codebase already.
Therefore, based on the repository owner's recommendation, I bumped to 0.6.x which fixes the CVE but in a backward compatible way with 0.4.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
Resolves https://nvd.nist.gov/vuln/detail/CVE-2023-0842
0.6.2 is backward compatible with 0.4.x (0.5.x introduced a non-backward-compatible fix for the CVE listed above). Therefore, this should be safe to treat as a bugfix version (e.g., 2.2.2).