Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spontaneous #775

Merged
merged 5 commits into from
Feb 26, 2025
Merged

Spontaneous #775

merged 5 commits into from
Feb 26, 2025

Conversation

bimac
Copy link
Contributor

@bimac bimac commented Feb 26, 2025

No description provided.

@bimac
Copy link
Contributor Author

bimac commented Feb 26, 2025

@nbonacchi sorry about that - it looks like you were still logged into one of our rig computers

@bimac bimac linked an issue Feb 26, 2025 that may be closed by this pull request
@bimac bimac requested a review from oliche February 26, 2025 15:53
@bimac bimac marked this pull request as ready for review February 26, 2025 15:54
@coveralls
Copy link

Coverage Status

Changes unknown
when pulling 5fe19a4 on spontaneous
into ** on iblrigv8dev**.

Copy link
Member

@oliche oliche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice patching for the tests.

One feedback from Jaime was to be able to set the delay, but I don't really see the point unless we can notify the user, as nothing really happens if the task stops and the experiment doesn t take the subject out.

So it looks good to me, and works on my machine

@oliche oliche merged commit dfef8fb into iblrigv8dev Feb 26, 2025
7 checks passed
@bimac bimac deleted the spontaneous branch February 26, 2025 18:25
@bimac
Copy link
Contributor Author

bimac commented Feb 26, 2025

One feedback from Jaime was to be able to set the delay, but I don't really see the point unless we can notify the user, as nothing really happens if the task stops and the experiment doesn t take the subject out.

If by delay you mean the session duration: this is already supported by the base class. It would only require the argument parser as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalize spontaneous task with spacers.
3 participants