-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.27.3 #769
8.27.3 #769
Conversation
bimac
commented
Feb 14, 2025
•
edited
Loading
edited
- tested on dev rig
- does not affect task logic
- passes unit-tests
- reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to assess the difficulty/usefulness of testing the pyspin functions, but there is no test here, is there ?
Also we saw that the entrypoints need testing, maybe with some form of integration test.
There are currently no tests for the PySpin functions, correct. It may be possible to do this with plenty of mocking, but since PySpin is mostly a wrapper to the Spinnaker C++ SDK it would be very cumbersome and the benefits questionable. PySpin doesn't currently affect the core functionality of IBLRIG, so I would give testing a lower priority in this case.
Yes, I'll look into this. |
Moving to pydantic_settings should make it easier to test the CLI argument parsing: #770 |