Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.27.3 #769

Merged
merged 12 commits into from
Feb 19, 2025
Merged

8.27.3 #769

merged 12 commits into from
Feb 19, 2025

Conversation

bimac
Copy link
Contributor

@bimac bimac commented Feb 14, 2025

  • tested on dev rig
  • does not affect task logic
  • passes unit-tests
  • reviewed

@bimac bimac requested a review from oliche February 14, 2025 17:24
@coveralls
Copy link

coveralls commented Feb 14, 2025

Coverage Status

coverage: 47.388% (-0.3%) from 47.663%
when pulling 1b5c220 on iblrigv8dev
into b6bd70f on iblrigv8.

@bimac bimac requested a review from k1o0 February 18, 2025 09:37
Copy link
Member

@oliche oliche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to assess the difficulty/usefulness of testing the pyspin functions, but there is no test here, is there ?

Also we saw that the entrypoints need testing, maybe with some form of integration test.

@bimac
Copy link
Contributor Author

bimac commented Feb 19, 2025

It's hard to assess the difficulty/usefulness of testing the pyspin functions, but there is no test here, is there ?

There are currently no tests for the PySpin functions, correct. It may be possible to do this with plenty of mocking, but since PySpin is mostly a wrapper to the Spinnaker C++ SDK it would be very cumbersome and the benefits questionable. PySpin doesn't currently affect the core functionality of IBLRIG, so I would give testing a lower priority in this case.

Also we saw that the entrypoints need testing, maybe with some form of integration test.

Yes, I'll look into this.

@bimac bimac removed the request for review from k1o0 February 19, 2025 14:56
@bimac
Copy link
Contributor Author

bimac commented Feb 19, 2025

Also we saw that the entrypoints need testing, maybe with some form of integration test.

Moving to pydantic_settings should make it easier to test the CLI argument parsing: #770

@bimac bimac merged commit 7b986ae into iblrigv8 Feb 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants