Skip to content

Commit

Permalink
WIP(ui-select): experiment with shouldContainFocus
Browse files Browse the repository at this point in the history
Closes: INSTUI-4189
  • Loading branch information
joyenjoyer committed Sep 2, 2024
1 parent 2cf4255 commit dc869b1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/ui-select/src/Select/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -709,6 +709,7 @@ class Select extends Component<SelectProps> {
mountNode={mountNode}
positionTarget={this._inputContainer}
isShowingContent={isShowingOptions}
shouldContainFocus="screenreader"

Check failure on line 712 in packages/ui-select/src/Select/index.tsx

View workflow job for this annotation

GitHub Actions / chromatic_deployment

Type 'string' is not assignable to type 'boolean | undefined'.

Check failure on line 712 in packages/ui-select/src/Select/index.tsx

View workflow job for this annotation

GitHub Actions / Lint commit msg + code

Type 'string' is not assignable to type 'boolean | undefined'.

Check failure on line 712 in packages/ui-select/src/Select/index.tsx

View workflow job for this annotation

GitHub Actions / Cypress component tests

Type 'string' is not assignable to type 'boolean | undefined'.

Check failure on line 712 in packages/ui-select/src/Select/index.tsx

View workflow job for this annotation

GitHub Actions / Vitest unit tests

Type 'string' is not assignable to type 'boolean | undefined'.

Check failure on line 712 in packages/ui-select/src/Select/index.tsx

View workflow job for this annotation

GitHub Actions / Legacy unit tests

Type 'string' is not assignable to type 'boolean | undefined'.
shouldReturnFocus={false}
withArrow={false}
>
Expand Down

0 comments on commit dc869b1

Please sign in to comment.