Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility - Teacher - Settings - Fix big font size issue #3065

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ndrsszsz
Copy link
Contributor

affects: Teacher, Student
release note: None
test plan: Labels in Settings should appear correctly even with the maximum font size.

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

affects: Teacher, Student
release note: None
test plan: Labels in Settings should appear correctly even with the maximum font size.
@inst-danger
Copy link
Contributor

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Jan 14, 2025

Warnings
⚠️ This pull request will not generate a release note.
⚠️ One or more files are below the minimum test coverage 50%

Affected Apps: Teacher, Student

MBL-18330

Coverage New % Master % Delta
Canvas iOS 91.28% 91.29% -0.01%
Core/Core/Common/CommonModels/Store/FetchedCollection.swift 48.72% 48.72% 0%
Core/Core/Common/Extensions/Foundation/CGSizeExtensions.swift 0% 0% 0%
Core/Core/Features/Courses/SmartSearch/Model/CourseSmartSearchViewAttributes.swift 30.77% 30.77% 0%
Core/Core/Common/Extensions/SwiftUI/UIColor+Color.swift 0% 0% 0%
Core/Core/Features/Search/Model/SearchSupportButtonModel.swift 0% 0% 0%
Core/Core/Common/CommonModels/AppEnvironment/AppEnvironmentOverride.swift 32.76% 32.76% 0%

Generated by 🚫 dangerJS against bef0ecb

@ndrsszsz ndrsszsz dismissed suhaibabsi-inst’s stale review January 15, 2025 09:54

Requested change has been adressed.

Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants