Add swiftlint to tests (#20)

* check for existing links in checkText()

* Remove unnecessary closure parens

* Uses Set for text checking and adds tests

* Adds test case for html generated attributed strings

* Tweaks tests as per feedback from Chris

* Adds swiftlint to test sources and fixes linting errors

* fix linting issues broken from merge conflict

* Fix function duplication from merge conflict

.swiftlint.yml

@@ -27,4 +27,5 @@ disabled_rules:
 
 included:
   - Source
+  - Nantes/NantesTests
 

Nantes/NantesTests/AttributedStringExtensionTests.swift

@@ -6,23 +6,22 @@
 //  Copyright © 2019 Instacart. All rights reserved.
 //
 
-import XCTest
 @testable import Nantes
+import XCTest
 
 final class AttributedStringExtensionTests: XCTestCase {
-    
+
     private let testUrl = URL(string: "https://www.swiftjoe.com")!
-
     func testReturnsLinksIfFoundInAttributedString() {
         let linkString = NSAttributedString(string: "Contains a link", attributes: [.link: testUrl])
         let existingLinks = linkString.findExistingLinks()
         XCTAssertFalse(existingLinks.isEmpty)
     }
-    
+
     func testFindsLinksForAttributedStringsCreatedFromHTML() {
         let htmlString = "<a href=\"http://www.google.com\">I can be clicked\""
         guard let data = htmlString.data(using: .utf8) else {
-            XCTFail()
+            XCTFail("Could not get data detector")
             return
         }
         do {
@@ -33,35 +32,35 @@ final class AttributedStringExtensionTests: XCTestCase {
             let existingLinks = attributedString.findExistingLinks()
             XCTAssert(existingLinks.count == 1)
         } catch {
-            XCTFail()
+            XCTFail("Could not get data detector")
         }
     }
-    
+
     func testReturnsLinkIsEmptyIfNoAttributedLink() {
         let linkString = NSAttributedString(string: "Contains no links at all")
         let checkingResults = linkString.findExistingLinks()
         XCTAssertTrue(checkingResults.isEmpty)
     }
-    
+
     func testCheckingResultsIsEmptyIfAttributedStringContainsAttributedLink() {
         do {
             let detector = try NSDataDetector(types: NantesLabel().enabledTextCheckingTypes.rawValue)
             let linkString = NSAttributedString(string: "Contains a link", attributes: [.link: testUrl])
             let checkingResults = linkString.findCheckingResults(usingDetector: detector)
             XCTAssertTrue(checkingResults.isEmpty)
         } catch {
-            XCTFail()
+            XCTFail("Could not get data detector")
         }
     }
-    
+
     func testCheckingResultsContainsValueIfDataFoundInString() {
         do {
             let detector = try NSDataDetector(types: NantesLabel().enabledTextCheckingTypes.rawValue)
             let linkString = NSAttributedString(string: "867-5309")
             let checkingResults = linkString.findCheckingResults(usingDetector: detector)
             XCTAssert(checkingResults.count == 1)
         } catch {
-            XCTFail()
+            XCTFail("Could not get data detector")
         }
     }
 }

Nantes/NantesTests/NantesTests.swift

@@ -6,8 +6,11 @@
 //  Copyright © 2019 Instacart. All rights reserved.
 //
 
-import XCTest
 @testable import Nantes
+import XCTest
+
+// swiftlint:disable force_cast
+// swiftlint:disable force_try
 
 final class NantesLabelTests: XCTestCase {
     var label: NantesLabel = .init(frame: .zero)
@@ -215,35 +218,35 @@ final class NantesLabelTests: XCTestCase {
         XCTAssertEqual(updatedParagraphStyle.maximumLineHeight, 42)
         XCTAssertEqual(updatedKern.intValue, 32)
     }
-    
+
     func testExistingAttributedLinksAreAddedAsNantesLinks() {
         let testUrl = URL(string: "https://www.swiftjoe.com")!
         let linkString = NSAttributedString(string: "Contains a link", attributes: [.link: testUrl])
-        
+
         let promise = expectation(description: "waiting for attributes to be set")
         XCTAssertTrue(label.linkModels.isEmpty)
         label.attributedText = linkString
-        
+
         DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
             promise.fulfill()
         }
-        
+
         XCTWaiter().wait(for: [promise], timeout: 2)
         XCTAssertFalse(label.linkModels.isEmpty)
     }
-    
+
     func testMultipleLinksAreAdded() {
         let testUrl = URL(string: "https://www.instacart.com")!
         let linkString = NSMutableAttributedString(string: "Link 1", attributes: [.link: testUrl])
         linkString.append(NSAttributedString(string: "https://www.swiftjoe.com"))
         XCTAssertTrue(label.linkModels.isEmpty)
         label.attributedText = linkString
-        
+
         let promise = expectation(description: "waiting for attributes to be set")
         DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
             promise.fulfill()
         }
-        
+
         XCTWaiter().wait(for: [promise], timeout: 2)
         XCTAssertTrue(label.linkModels.count == 2)
     }