fix bug whre it was printing default round type at end of listings

insightsengineering · Feb 6, 2025 · abdb16f · abdb16f
1 parent 5d0dcfc
commit abdb16f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/R/rlistings_methods.R b/R/rlistings_methods.R
@@ -32,8 +32,7 @@ print.listing_df <- function(x,
         col_gap = col_gap,
         round_type = round_type,
         ...
-      ),
-      round_type = round_type
+      )
     )
   }, error = function(e) {
     if (nrow(x) == 0) {

diff --git a/man/listing_methods.Rd b/man/listing_methods.Rd
diff --git a/tests/testthat/test-print.R b/tests/testthat/test-print.R
@@ -3,6 +3,10 @@ testthat::test_that("Listing print correctly", {
     add_listing_col("ARM")
 
   res <- strsplit(toString(matrix_form(lsting), hsep = "-"), "\\n")[[1]]
+  ## regression
+  printout <- capture.output(print(lsting, hsep = "-"))
+  testthat::expect_false(any(grepl("iec", printout, fixed = TRUE)))
+  testthat::expect_identical(res, printout)
 
   testthat::expect_snapshot(res)
 })