Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add files for repo to match nest style #3

Merged
merged 7 commits into from
Oct 28, 2024
Merged

Conversation

ayogasekaram
Copy link
Contributor

@ayogasekaram ayogasekaram commented Oct 16, 2024

add files and workflows to match NEST repo style


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Copy link
Contributor

github-actions bot commented Oct 16, 2024

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------
R/tbl_demographics.R            34      34  0.00%    44-79
R/theme_gtsummary_roche.R       13      13  0.00%    22-40
TOTAL                           47      47  0.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: d06c430

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@ayogasekaram ayogasekaram requested a review from edelarua October 25, 2024 19:42
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! One grammar suggestion but otherwise should be good to go once you resolve the dependency checks. Thanks Abi!!

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@edelarua
Copy link
Contributor

Let me know if you add more and need another review! :)

@edelarua edelarua added the sme label Oct 25, 2024
Co-authored-by: Emily de la Rua <[email protected]>
Signed-off-by: Abinaya Yogasekaram <[email protected]>
@ayogasekaram
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@cicdguy
Copy link

cicdguy commented Oct 28, 2024

recheck

Copy link
Contributor

github-actions bot commented Oct 28, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@ayogasekaram ayogasekaram merged commit 11137c1 into main Oct 28, 2024
33 checks passed
@ayogasekaram ayogasekaram deleted the 738_nestify_crane@main branch October 28, 2024 14:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants