prep_aria: support for ARIA product v3 correction layers

[sssangha]

Description of proposed changes

Reminders

• Fix #xxxx
• Pass Pre-commit check (green)
• Pass Codacy code review (green)
• Pass Circle CI test (green)
• Make sure that your code follows our style. Use the other functions/files as a basis.
• If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
• If adding new functionality, add a detailed description to the documentation and/or an example.

[dbekaert]

@sssangha @yunjunz Can we move this PR along? Any updated needed @yunjunz?

[yunjunz]

Thank you @sssangha and @mgovorcin for the PR. Besides the comments above, could you also fix the suggestions from pre-commit and codacy checking?

[yunjunz]

@sssangha @dbekaert I have made some suggestions for this PR. It would be great if it can be updated and moved forward.

[codeautopilot]

PR summary

This Pull Request introduces support for ARIA product version 3 correction layers in the prep_aria module. The changes include the ability to load and process correction layers such as troposphere, ionosphere, and solid earth tides. The PR modifies existing functions to handle these new inputs and adds new functions to write correction data to HDF5 files. The update aims to enhance the processing of ARIA data by incorporating these correction layers, which can improve the accuracy of the interferometric products.

Suggestion

1. Ensure that all new functions and modifications are well-documented, including input parameters and expected behavior, to maintain code readability and ease of use.
2. Consider adding unit tests for the new functionalities to ensure they work as expected and to prevent future regressions.
3. Review the handling of multiple troposphere files to ensure that the logic is robust and handles edge cases effectively.

Disclaimer: This comment was entirely generated using AI. Be aware that the information provided may be incorrect.

Current plan usage: 0.00%

Have feedback or need help?
Discord
Documentation
[email protected]

[EJFielding]

I hope this addition can be completed soon. We can really use this ionospheric layer support to advance our NISAR Calibration and Validation activities that use ARIA S1-GUNW files.

[mgovorcin]

All @yunjunz suggestions have been addressed, @ehavazli or @rzinke please remove unused args from cli/prep_aria.py before the merge.

[yunjunz]

All @yunjunz suggestions have been addressed, please remove unused args from cli/prep_aria.py before the merge.

Great. I tried to test it last week, but the environment needs to be updated for the new ARIA-tools. I will try it again this weekend.

[EJFielding]

We found recently that the conda-forge ARIA-tools requires Python 3.12 but ISCE2 only allows versions up to 3.11, so it is not presently possible to make a conda environment with ISCE2, ARIA-tools, and MintPy.

[yunjunz]

Thanks for the heads-up @EJFielding, I will create a new env for this test then.

[ehavazli]

Hi @yunjunz and @EJFielding, what's the current status of this PR on your end?

[yunjunz]

Hi @yunjunz and @EJFielding, what's the current status of this PR on your end?

I won't have time to test the change in the coming few days. Since the PR only changes code in prep_aria, it's fine with me to merge as long as others confirm it works. @EJFielding ?