Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ci): use cache-version instead of 'v0-' in rust cache key prefix #2323

Merged
merged 2 commits into from
Feb 20, 2025
Merged

refactor(ci): use cache-version instead of 'v0-' in rust cache key prefix #2323

merged 2 commits into from
Feb 20, 2025

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Feb 20, 2025 •
edited
Loading

Content

This PR simplify the prefix for rust cache in CI.

Previously we had a version two times: 

v0-rust-Linux-cache-v5d9f9d8e-fb2b-4423-9700-8ae3bc62978e-cargo-doc-Linux-e99b5096-e698f932

Now, alongside a change of the repository cache-version to a simple 2: 
v2-rust-Linux-cache-cargo-doc-Linux-e99b5096-e698f932

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@Alenar Alenar self-assigned this Feb 20, 2025
@Alenar
refactor(ci): use a repository var instead of a secret for cache version
7812d29 
Since it's not a sensible data and this avoid obfuscations of occurences
of the cache version value in CI logs.
@github-actions GitHub Actions
Copy link

Test Results

    3 files  ±0     52 suites  ±0   10m 45s ⏱️ +21s
1 645 tests ±0  1 645 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 929 runs  ±0  1 929 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7812d29. ± Comparison against base commit 01e15ab.

@Alenar Alenar temporarily deployed to testing-preview February 20, 2025 12:30 — with GitHub Actions Inactive
@Alenar Alenar merged commit fc119af into main Feb 20, 2025
35 of 39 checks passed
@Alenar Alenar deleted the djo/ci/simplify-rust-cache-key branch February 20, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@dlachaume dlachaume dlachaume approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@Alenar Alenar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alenar @jpraynaud @dlachaume