-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert commit 4534b6eae64072a87bd81584f479a123681358a3 #153
Merged
bolt12
merged 9 commits into
main
from
bolt12/revert-4534b6eae64072a87bd81584f479a123681358a3
May 8, 2024
Merged
Revert commit 4534b6eae64072a87bd81584f479a123681358a3 #153
bolt12
merged 9 commits into
main
from
bolt12/revert-4534b6eae64072a87bd81584f479a123681358a3
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
requested changes
May 6, 2024
This introduced a regression where IOSimPOR could not handle infinite simulations.
3117d62
to
6647c91
Compare
coot
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7 tasks
coot
approved these changes
May 6, 2024
dee22f8
to
fa3c7b9
Compare
756abae
to
f6005c2
Compare
a0d0006
to
ef3fd6c
Compare
720342d
to
8484627
Compare
coot
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduced a regression where IOSimPOR could not handle infinite simulations.
Closes: #151