Fix/correct keyword state topic information #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -665,7 +665,7 @@ def _update_state_from_adapter(self, order_state: VDAOrderState): | |||
| "distance_since_last_node": order_state.state.distance_since_last_node, | |||
| "battery_state": order_state.state.battery_state, | |||
| "errors": current_errors + order_state.state.errors, | |||
| "informations": order_state.state.informations | |||
| "information": order_state.state.information | |||
There was a problem hiding this comment.
Hey @bekirbostanci for this to work the field must also be renamed in vda5050_msgs/msg/OrderState.msg, right ?
There was a problem hiding this comment.
yes you are right I changed in my workspace however I forgot it,
There was a problem hiding this comment.
I changed it also the message
Changed informations key to information
bekirbostanci
changed the title
|
Code looks good to me ! Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State message include information part and this key name is not correct in the script
Correct name of the key is not informations it is information