-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer usability improvements #5707
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -0,0 +1,6 @@ | |||
description: "Change information in the Form Modal to be more adequate when no instance is chosen, Make expand/collapse button action area bigger." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps specify it is in the composer?
src/UI/words.tsx
Outdated
@@ -145,6 +145,8 @@ const dict = { | |||
"inventory.editInstance.failed": "Editing instance failed", | |||
"inventory.editInstance.noAttributes": | |||
"There are no attributes to edit. Click confirm to move into the update state", | |||
"inventory.addInstance.noAttributes": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"inventory.addInstance.noAttributes": | |
"inventory.addInstance.unselectedEntity": |
LukasStordeur
approved these changes
Apr 30, 2024
Processing this pull request |
inmantaci
pushed a commit
that referenced
this pull request
Apr 30, 2024
…hen no instance is chosen, Make expand/collapse button action area bigger in the Instances on the Instance Composer Canvas. (Issue #5691, PR #5707) # Description * Short description here * closes #5690 #5691 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Code is clear and sufficiently documented - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) https://github.com/inmanta/web-console/assets/113331659/e0a1b3df-d5a9-4198-aac5-5d0a97b91bdf
Merged into branches iso7, master in f97c50c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #5690 #5691
Self Check:
Strike through any lines that are not applicable (
~~line~~
) then check the boxScreen.Recording.2024-04-24.at.10.34.35.mov