Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer usability improvements #5707

Closed

Conversation

matborowczyk
Copy link
Collaborator

Description

  • Short description here *

closes #5690 #5691

Self Check:

Strike through any lines that are not applicable (~~line~~) then check the box

  • Attached issue to pull request
  • Changelog entry
  • Code is clear and sufficiently documented
  • Sufficient test cases (reproduces the bug/tests the requested feature)
  • Correct, in line with design
  • End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
Screen.Recording.2024-04-24.at.10.34.35.mov

@matborowczyk matborowczyk self-assigned this Apr 24, 2024
@matborowczyk matborowczyk linked an issue Apr 24, 2024 that may be closed by this pull request
@@ -0,0 +1,6 @@
description: "Change information in the Form Modal to be more adequate when no instance is chosen, Make expand/collapse button action area bigger."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps specify it is in the composer?

src/UI/words.tsx Outdated
@@ -145,6 +145,8 @@ const dict = {
"inventory.editInstance.failed": "Editing instance failed",
"inventory.editInstance.noAttributes":
"There are no attributes to edit. Click confirm to move into the update state",
"inventory.addInstance.noAttributes":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"inventory.addInstance.noAttributes":
"inventory.addInstance.unselectedEntity":

@matborowczyk matborowczyk added the merge-tool-ready This ticket is ready to be merged in label Apr 30, 2024
@inmantaci
Copy link
Contributor

Processing this pull request

inmantaci pushed a commit that referenced this pull request Apr 30, 2024
…hen no instance is chosen, Make expand/collapse button action area bigger in the Instances on the Instance Composer Canvas. (Issue #5691, PR #5707)

# Description

* Short description here *

closes #5690 #5691

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Code is clear and sufficiently documented
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

https://github.com/inmanta/web-console/assets/113331659/e0a1b3df-d5a9-4198-aac5-5d0a97b91bdf
@inmantaci
Copy link
Contributor

Merged into branches iso7, master in f97c50c

@inmantaci inmantaci closed this Apr 30, 2024
@inmantaci inmantaci deleted the issue/5691-composer-usability-improvements branch April 30, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-tool-ready This ticket is ready to be merged in
Projects
None yet
3 participants